-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added note about "use client" to React docs #584
Conversation
✅ Deploy Preview for eppo-data-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What sparked this change--I don't think Next.js would be at play if React Native is. Did you mean to make a modification in our javascript client docs? If so, perhaps you could also include a "see this next.js guide for more detail"
This is in the javascript docs, just on the dedicated React page (not React Native) The prompt for this was that I was setting up a Next JS app and going off of the React docs (I ended up here from the link "using with React" in the flagging quick start). If I was really paying attention, I would have seen the "Next JS" thing in the sidebar, but from my (very limited) understanding of the JS universe, it seems like it's fairly possible to imagine another reader going through this same arc. Lmk if you disagree though I can add a link to the Next JS docs too, that's a good call |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update.
Just needs a small change to fix the link in your note.
Co-authored-by: Tyler Potter <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is in the javascript docs, just on the dedicated React page (not React Native)
Oh right! Expectation bias. This is great, thanks for doing this!
We have dedicated Next.js docs, but I figure this is easy enough to get tripped up on that it's worth adding a callout