Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added note about "use client" to React docs #584

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

lukasgoetzweiss
Copy link
Contributor

We have dedicated Next.js docs, but I figure this is easy enough to get tripped up on that it's worth adding a callout

Copy link

netlify bot commented Jan 31, 2025

Deploy Preview for eppo-data-docs ready!

Name Link
🔨 Latest commit 3a7a7e3
🔍 Latest deploy log https://app.netlify.com/sites/eppo-data-docs/deploys/67a2e5b7dc64e00008f9d94b
😎 Deploy Preview https://deploy-preview-584--eppo-data-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@aarsilv aarsilv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What sparked this change--I don't think Next.js would be at play if React Native is. Did you mean to make a modification in our javascript client docs? If so, perhaps you could also include a "see this next.js guide for more detail"

@lukasgoetzweiss
Copy link
Contributor Author

What sparked this change--I don't think Next.js would be at play if React Native is. Did you mean to make a modification in our javascript client docs? If so, perhaps you could also include a "see this next.js guide for more detail"

This is in the javascript docs, just on the dedicated React page (not React Native)

The prompt for this was that I was setting up a Next JS app and going off of the React docs (I ended up here from the link "using with React" in the flagging quick start).

If I was really paying attention, I would have seen the "Next JS" thing in the sidebar, but from my (very limited) understanding of the JS universe, it seems like it's fairly possible to imagine another reader going through this same arc.

Lmk if you disagree though

I can add a link to the Next JS docs too, that's a good call

Copy link
Collaborator

@typotter typotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update.
Just needs a small change to fix the link in your note.

Copy link
Contributor

@aarsilv aarsilv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in the javascript docs, just on the dedicated React page (not React Native)

Oh right! Expectation bias. This is great, thanks for doing this!

@lukasgoetzweiss lukasgoetzweiss merged commit 2e5870b into main Feb 5, 2025
4 checks passed
@lukasgoetzweiss lukasgoetzweiss deleted the lg/react-next-note branch February 5, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants