Skip to content

Commit

Permalink
Fixed syntax error on build
Browse files Browse the repository at this point in the history
Note: It's important to run npm pack to ensure that everything
actually passes.
  • Loading branch information
Nick Pleis committed Mar 29, 2023
1 parent a38ef14 commit c072943
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
4 changes: 2 additions & 2 deletions js-client-sdk-common.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export class EppoClient implements IEppoClient {
// Warning: (ae-forgotten-export) The symbol "IConfigurationStore" needs to be exported by the entry point index.d.ts
constructor(configurationStore: IConfigurationStore);
// (undocumented)
getAssignment(subjectKey: string, experimentKey: string, subjectAttributes?: {}): string;
getAssignment(subjectKey: string, experimentKey: string, subjectAttributes?: {}): Promise<string>;
// (undocumented)
setLogger(logger: IAssignmentLogger): void;
}
Expand Down Expand Up @@ -55,7 +55,7 @@ export interface IAssignmentLogger {

// @public
export interface IEppoClient {
getAssignment(subjectKey: string, experimentKey: string, subjectAttributes?: Record<string, any>): string;
getAssignment(subjectKey: string, experimentKey: string, subjectAttributes?: Record<string, any>): Promise<string>;
}

// @public (undocumented)
Expand Down
6 changes: 5 additions & 1 deletion src/client/eppo-client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,11 @@ export default class EppoClient implements IEppoClient {

constructor(private configurationStore: IConfigurationStore) {}

async getAssignment(subjectKey: string, experimentKey: string, subjectAttributes = {}): string {
async getAssignment(
subjectKey: string,
experimentKey: string,
subjectAttributes = {},
): Promise<string> {
validateNotBlank(subjectKey, 'Invalid argument: subjectKey cannot be blank');
validateNotBlank(experimentKey, 'Invalid argument: experimentKey cannot be blank');

Expand Down

0 comments on commit c072943

Please sign in to comment.