feat: move buildStorageKeySuffix function to common and bump release
#207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 31, 2025
…keysuffix-to-common
felipecsl
approved these changes
Jan 31, 2025
src/obfuscation.ts
Outdated
| */ | ||
| export function buildStorageKeySuffix(apiKey: string): string { | ||
| // Note that we hash the API key and use the last 16 characters of the digest. | ||
| return new SparkMD5().append(apiKey).end().slice(-16); |
There was a problem hiding this comment.
do we need to check for bounds here?
There was a problem hiding this comment.
Since we're hashing, taking the first or last characters will be sufficiently entropic.
Changed the slice call here to take the first 16 characters. slice is resilient to parameters larger than the length of the sting.
typotter
deleted the
typo/ff-3920-js-common-sdk-move-buildstoragekeysuffix-to-common
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
labels: mergeable
Fixes: FF-3920
Motivation and Context
This method is used by both react-native and js-client SDKs so rather than duplicate, we'll move it to common. Also, this moves the algorithm to use a hash instead of just slicing the API key to avoid leaking sensitive info. This also makes suffix collisions much less likely