bug: [add support for json arrays in variant values] (FF-2947) #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
observation
bug report observed that variation values with top level JSON arrays were throwing an exception, in the android SDK: https://github.com/Eppo-exp/android-sdk/blob/b95c1ce20b6b433a2b8722144e6edb5996e7cf4a/eppo/src/main/java/cloud/eppo/android/EppoClient.java#L438
changes
I was tracing the code to determine where the parsing was happening and updated the unit tests in this repo.
Have learned that there is no direct support for JSON objects in this repo, so no broken tests to fix. Just augmenting them in this PR.
A few things to consider:
flags-v1.jsonin this repo but no easy way to update it: consider using a Makefile to clone the repo or make the test data repo a submodule.