Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed RevEngWizardHandler and updated ReverseEngineerHandler with Wizard code #2819

Closed
wants to merge 6 commits into from

Conversation

BillKrat
Copy link
Contributor

Removed preview reverse engineering menu, updated ReverseEngineerHandler with RevEngWizardHandler code [removed RevEngWizardHandler class].

@ErikEJ
Copy link
Owner

ErikEJ commented Feb 1, 2025

@BillKrat I have published a new marketplace release, and will have a look at this PR soon.

@ErikEJ
Copy link
Owner

ErikEJ commented Feb 1, 2025

Are some of the Dialogs not used any more and can be removed?

…y EfCoreModelDialog is no longer in use - removed
@BillKrat
Copy link
Contributor Author

BillKrat commented Feb 1, 2025

Good question, you may have been able to glean from the PR noise that I originally removed the dialogs only to discover during testing that they were used by other handlers. I restored them to complete testing and meant to come back to assess that; your question reminded me and below are the results of my research.

I removed the EFCoreModelDialog and its view model [updated the PR] as it was the only dialog orphaned by wizard work. Note: I do reuse the same interface for the Wiz3_EFCoreModelDialog page.

EFPT_ViewsHandlers

@ErikEJ
Copy link
Owner

ErikEJ commented Feb 1, 2025

@BillKrat Just found a bug, that must be fixed berfore we can merge this

@ErikEJ
Copy link
Owner

ErikEJ commented Feb 2, 2025

@BillKrat Maybe it would be simpler to just remove the legacy menu option and rename the wizard option? (Could even leave the "old" code behind for now)

@ErikEJ ErikEJ closed this Feb 2, 2025
@BillKrat
Copy link
Contributor Author

BillKrat commented Feb 2, 2025

Good idea @ErikEJ, that would make it a lot simpler. This way when you are ready to go officially with wizard you can do so with minor changes. We can revisit old code when we look at wizards for other handlers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants