fix: add __typename to the default value of allowList #767
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #738, supersedes #766
There is a GraphQL vulnerability related to allowing an unlimited number of aliases of
__typename
- an attacker can craft a query that consists of tens of thousands of aliases, like{"query": "query aliasOverLoad { alias0: __typename alias1: __typename alias2: __typename alias3: __typename alias4: __typename alias5: __typename <...thousands more> }"}
and can be a way to bypass authentication on the API because it does not hit any resolvers. With enough simultaneous queries like this it can fairly easily bring down a server.In #468 the behavior of the max aliases plugin was modified to permanently omit aliases of
__typename
from the alias count. This PR builds on those changes by setting the default value ofallowList
to["__typename"]
so that consumers can opt out of this behavior, while maintaining backwards compatibility.