Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libraries and phrasing for 2.4 in the system requirements page #2221

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jyaistMap
Copy link
Collaborator

The new page would appear like this:

image image image

@jyaistMap jyaistMap added the documentation Bugs and enhancement requests for doc (API ref and notebooks) label Feb 11, 2025
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@cariashuang0417 cariashuang0417 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to build doc locally with the guides and samples, but not api-ref yet. Other than an empty code block that can be removed at the bottom of the page, overall looks good to me!
image

Just a question about the packages versions. I am seeing some differences between the listed packages and the geosaurus/src/setup.py file. Should we align the versions based on setup.py, or there is somewhere else we can check with the versions?

@jyaistMap
Copy link
Collaborator Author

jyaistMap commented Feb 19, 2025

@cariashuang0417

  • These versions are based on internal meta.yml file. I added a note to indicate version may vary with pip since it uses setup.py:

image

  • I removed that last cell

Copy link
Contributor

@cariashuang0417 cariashuang0417 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on local doc build on windows. Thanks John 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Bugs and enhancement requests for doc (API ref and notebooks)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants