fix(combobox): ensure disabled items get proper scale (#11400)

**Related Issue:** #9888 ## Summary Copied the scale and selectionMode to disabled items; fixed broken test.
Esri · Jan 29, 2025 · 49cc976 · 49cc976
1 parent f82bb5e
commit 49cc976
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/packages/calcite-components/src/components/combobox/combobox.e2e.ts b/packages/calcite-components/src/components/combobox/combobox.e2e.ts
@@ -2593,9 +2593,10 @@ describe("calcite-combobox", () => {
         <calcite-combobox-item-group label="Conifers">
           <calcite-combobox-item value="Pine" text-label="Pine"></calcite-combobox-item>
         </calcite-combobox-item-group>
+        <calcite-combobox-item value="DisabledItem" text-label="DisabledItem" disabled></calcite-combobox-item>
       </calcite-combobox>
     `);
-    const comboboxItems = await page.findAll("calcite-combobox-items");
+    const comboboxItems = await page.findAll("calcite-combobox-item");
 
     for (const item of comboboxItems) {
       expect(await item.getProperty("selectionMode")).toBe("single");

diff --git a/packages/calcite-components/src/components/combobox/combobox.tsx b/packages/calcite-components/src/components/combobox/combobox.tsx
@@ -1245,7 +1245,7 @@ export class Combobox
   }
 
   private updateItemProps(): void {
-    this.items.forEach((item) => {
+    this.getItems(true).forEach((item) => {
       item.selectionMode = this.selectionMode;
       item.scale = this.scale;
     });