chore(linting): drop TSLint (#3009)

* replaces prefer-conditional-expression rule with unicorn/prefer-ternary
* removes remaining tslint-stencil rules used to warn about component/lifecycle order

#791

.eslintrc.json

@@ -16,7 +16,7 @@
     "ecmaVersion": 2018,
     "sourceType": "module"
   },
-  "plugins": ["@esri/calcite-components", "@typescript-eslint", "eslint-plugin-react", "jest", "prettier"],
+  "plugins": ["@esri/calcite-components", "@typescript-eslint", "eslint-plugin-react", "jest", "prettier", "unicorn"],
   "rules": {
     "@stencil/decorators-style": "warn",
     "@stencil/own-methods-must-be-private": "off",
@@ -52,7 +52,8 @@
     "react/jsx-sort-props": "error",
     "react/jsx-uses-react": "error",
     "react/jsx-uses-vars": "error",
-    "react/self-closing-comp": "error"
+    "react/self-closing-comp": "error",
+    "unicorn/prefer-ternary": "error"
   },
   "settings": {
     "react": {

.lintstagedrc.json

@@ -3,5 +3,5 @@
   "*.js": ["eslint --ext .js --fix", "prettier --write"],
   "*.{json,md}": ["prettier --write"],
   "*.scss": ["stylelint --fix", "prettier --write"],
-  "*.{ts,tsx}": ["tslint --project tsconfig-tslint.json --fix", "eslint --ext .ts,.tsx --fix", "prettier --write"]
+  "*.{ts,tsx}": ["eslint --ext .ts,.tsx --fix", "prettier --write"]
 }

CONTRIBUTING.md

@@ -29,7 +29,7 @@ If something isn't working the way you expected, please take a look at [previous
 
 ### Getting a development environment set up
 
-It is recommended to install the following extensions to your editor of choice: TypeScript, Sass, TailwindCSS, ESLint, TSLint and Prettier.
+It is recommended to install the following extensions to your editor of choice: TypeScript, Sass, TailwindCSS, ESLint and Prettier.
 
 #### Linting