Skip to content

Commit

Permalink
ci: lint monorepo (#11348)
Browse files Browse the repository at this point in the history
**Related Issue:** #11243 #11312

## Summary

Fix a linting error that was likely committed before the author's branch
was synced with the rule changes linked above. The linting error caused
issues committing during merge conflict resolution.
  • Loading branch information
benelan authored Jan 21, 2025
1 parent a7dc494 commit d47de54
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ Calcite follows [Conventional Commits](https://www.conventionalcommits.org/en/v1
Contributions should adhere to the `<type>(<scope>): <descriptive summary>` format and include the following:

- [Commit type](#commit-type)
- [Scope of change](#scope-of-change), _optional_
- [Scope of change](#scope-of-change), *optional*
- [Descriptive commit subject](#descriptive-commit-subject)

Check out the [contribution example](#contribution-example) for a formatted example, and explore [breaking change formatting](#breaking-changes) for consideration during Calcite's breaking change releases.
Expand All @@ -240,7 +240,7 @@ Contributions must adhere to **one** of the following types:

### Scope of change

_Optional_. Most contributions will include a scope, such as a component, multiple components, test(s), or utilities. For example:
*Optional*. Most contributions will include a scope, such as a component, multiple components, test(s), or utilities. For example:

- `text-area`
- `dropdown, dropdown-group, dropdown-item`
Expand Down
2 changes: 2 additions & 0 deletions packages/calcite-components/src/utils/loadable.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ export interface LoadableComponent {}
*
* @param _component
*/
// eslint-disable-next-line @typescript-eslint/no-unused-vars -- this method is deprecated, and we allow it to be empty for incremental migration
export function setUpLoadableComponent(_component: LoadableComponent): void {
// intentionally empty
}
Expand All @@ -74,6 +75,7 @@ export function setUpLoadableComponent(_component: LoadableComponent): void {
*
* @param _component
*/
// eslint-disable-next-line @typescript-eslint/no-unused-vars -- this method is deprecated, and we allow it to be empty for incremental migration
export function setComponentLoaded(_component: LoadableComponent): void {
// intentionally empty
}
Expand Down

0 comments on commit d47de54

Please sign in to comment.