Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Alert supporting actions-end #2382

Closed
Tracked by #5665
bstifle opened this issue Jun 23, 2021 · 7 comments
Closed
Tracked by #5665

Enhancement: Alert supporting actions-end #2382

bstifle opened this issue Jun 23, 2021 · 7 comments
Assignees
@geospatialem @benelan
Labels
4 - verified Issues that have been released and confirmed resolved. enhancement Issues tied to a new feature or request.
Milestone
Sprint 2022/11/20...

Comments

@bstifle
Copy link

bstifle commented Jun 23, 2021

Description

alert needs to support up to 2 actions in the end slot next to the X

image
@bstifle bstifle added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jun 23, 2021
@bstifle
Copy link
Author

bstifle commented Jun 23, 2021

hover and hit space to match X

@bstifle bstifle mentioned this issue Jul 2, 2021
Merged
@jcfranco jcfranco added this to the Sprint 7/19 – 7/30 milestone Jul 2, 2021
@jcfranco jcfranco added help wanted Issues that the core team needs help with in a sprint. and removed needs triage Planning workflow - pending design/dev review. labels Jul 2, 2021
@macandcheese macandcheese mentioned this issue Sep 24, 2021
Closed
2 tasks
@macandcheese
Copy link
Contributor

@asangma - planned update regarding our chat yesterday... would be solvable with the slot paradigm.

@benelan benelan self-assigned this May 10, 2022
@benelan benelan added design Issues that need design consultation prior to development. 1 - assigned Issues that are assigned to a sprint and a team member. and removed help wanted Issues that the core team needs help with in a sprint. 0 - new New issues that need assignment. labels May 16, 2022
@benelan benelan assigned asangma and unassigned benelan May 16, 2022
@benelan benelan modified the milestones: Freezer, Sprint 06/06 - 06/17 May 16, 2022
@ashetland ashetland mentioned this issue Oct 28, 2022
Closed
@ashetland
Copy link
Contributor

Design complete in Figma. Updated design also addresses issues #5254 and #3338. cc: @geospatialem

@geospatialem geospatialem mentioned this issue Oct 28, 2022
Closed
5 tasks
@geospatialem geospatialem added 0 - new New issues that need assignment. and removed design Issues that need design consultation prior to development. 1 - assigned Issues that are assigned to a sprint and a team member. labels Oct 28, 2022
@jcfranco jcfranco added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Nov 9, 2022
@Elijbet Elijbet added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Nov 15, 2022
@Elijbet Elijbet mentioned this issue Nov 15, 2022
Merged
@geospatialem
Copy link
Member

@Elijbet Is the alert with actions-end ready for verification, and/or should we move this into the January release milestone?

@Elijbet Elijbet added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Dec 2, 2022
@github-actions github-actions bot assigned benelan and geospatialem and unassigned Elijbet Dec 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

Installed and assigned for verification.

@Elijbet
Copy link
Contributor

Elijbet commented Dec 2, 2022

@Elijbet Is the alert with actions-end ready for verification, and/or should we move this into the January release milestone?

It's ready. Just changed the tag.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Dec 6, 2022
@geospatialem
Copy link
Member

Verified on next.658 when slotting a calcite-action.

<calcite-alert open>
    <div slot="title">Alert title</div>
    <div slot="message">Message lorem ipsum</div><a slot="link" href="#">Link slot</a>
  <calcite-action slot="actions-end" text="Settings" icon="gear"></calcite-action>
  <calcite-action slot="actions-end" text="Information" icon="information"></calcite-action>
</calcite-alert>

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@benelan benelan

Labels
4 - verified Issues that have been released and confirmed resolved. enhancement Issues tied to a new feature or request.
Projects
None yet
Milestone
Sprint 2022/11/20 - 2022/12/01
Development

No branches or pull requests
9 participants
@jcfranco @macandcheese @geospatialem @benelan @asangma @bstifle @Elijbet @Apahadi73 @ashetland