fix(alert, notice): update leading and close icons to follow calcite-action icon sizing

[jcfranco]

Related Issue: #2417

Summary

This updates alert and notice's x and start icons as follows:

• when component scale is medium => use small scale for icons
• when component scale is large => use medium scale for icons
• when component scale is small => no change

notice

alert

[bstifle]

@jcfranco looks good, but would like to see both demo pages updated with examples that have actions in them if you dont mind

small medium and large with alert and notice would be 💯

I'll approve branch once thats reviewed

[jcfranco]

@bstifle Unlike notice, alert doesn't have a specific slot for actions.

[bstifle]

gotcha gotcha.

i suppose we'll add those later with #2382

[bstifle]

@jcfranco looks like small actions are a bit off on the width

can we get these to match the X (close button) padding?

[jcfranco]

Sure, but that means updating calcite-action's padding for small scale globally (from sizing-2 to sizing-3). Is that OK?

[julio8a]

I think I have this in my PR for action-bar, to update the padding on action. It's the spacing between the icon and the title. Not sure if it's the same but thought I'd bring it up.

https://github.com/Esri/calcite-components/pull/2429/files#diff-4c5550b21bcb6014dcecc11ee9b564798b1231a352538340cb9fabef70917489R110

[jcfranco]

@julio8a Thanks for bringing it up. I tested your branch and it looks like the close buttons still need to be tweaked. I synced-up w/ @bstifle and I'll be modifying the padding on the close buttons for consistency.

Before pushing, can you confirm this is the spacing we want for the small scale?

[jcfranco]

I forgot to add these:

notice

alert

@bstifle @macandcheese does this change look good? I had to tweak the small scale var that is used to pad the sides of the alert/notice to make the sizes match.

[jcfranco]

Synced up w/ @bstifle and rolled back my last change since it affected more than the close buttons. Updated the PR to only modify spacing for small scale close icons.

[bstifle]

lookin real good, waiting on screener

[jcfranco]

@bstifle I see the same spacing (aside from icons) when I compare storybook on master and this branch. Proceeding to merge based on that.