Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic: Ensure parts of graphical objects essential for understanding content have sufficient contrast - (2036570198) #7822

Closed
dqateam opened this issue Sep 19, 2023 · 3 comments
Labels
0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. design Issues that need design consultation prior to development. needs triage Planning workflow - pending design/dev review.

Comments

@dqateam
Copy link
Collaborator

dqateam commented Sep 19, 2023

Violation:

Ensure parts of graphical objects essential for understanding content have sufficient contrast across the design system for the following components with the --calcite-color-border-input css prop and border-color-input tailwind util:

This looks to relate to the --calcite-color-background [More details]:

  1. calcite-mode-light (#F8F8F8) with the outline of the input (#949494), where the contrast ratio is 2.85:1.
  2. calcite-mode-dark (#353535) with the outline of the input (#757575), where the contrast ratio is 2.66:1

calcite-mode-light:

image
image

calcite-mode-dark:

image
image

Screenshots

image
image
image
image
image

image
image
image

WCAG Reference:

Severity:

5

Media Type:

Color and Contrast


Areas for Remediation:

  • Title: Switch - Ensure parts of graphical objects essential for understanding content have sufficient contrast - (2036570197)
  • Module: Switch
    Issue
    There are graphical objects with a color contrast ratio below 3.00: 1.

Foreground: #949494
Background: #F8F8F8
Contrast ratio: 2.86:1

Examples of text with this contrast ratio include:

  • Switch images.

User Impact
Users with low vision will have difficulty reading this content.

Suggestion
Ensure parts of graphical objects essential for understanding content have sufficient contrast. The required minimum contrast ratio is 3.00:1.

Common examples of qualifying objects include lines in a chart, meaningful icons, and annotations within an image.

Graphics that require particular presentation to preserve their meaning are exempt from this requirement.

To evaluate color contrast, see the Accessible Color Picker extension: https://www.accessibility.dev/


Additional Resources:

  • Report Source: Product accessibility evaluation conducted on the Calcite Design System in August, 2022.
@dqateam dqateam added 0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Sep 19, 2023
@geospatialem
Copy link
Member

While the light mode has sufficient contrast of 3.03:1, the dark mode contrast needs some improvement, currently at 2.66:1, which could be obtained with #808080 and a 3.1:1 ratio for the --calcite-color-border-input value, but adding design to this issue for their expertise.

image

Prototype: https://codepen.io/geospatialem/pen/abMOvmM

@geospatialem geospatialem added the design Issues that need design consultation prior to development. label Dec 27, 2023
@geospatialem geospatialem changed the title Switch - Ensure parts of graphical objects essential for understanding content have sufficient contrast - (2036570197) Switch - Ensure parts of graphical objects essential for understanding content have sufficient contrast - (2036570198) Dec 27, 2023
@geospatialem geospatialem changed the title Switch - Ensure parts of graphical objects essential for understanding content have sufficient contrast - (2036570198) Epic: Ensure parts of graphical objects essential for understanding content have sufficient contrast - (2036570198) Dec 27, 2023
@bsvensson bsvensson added the ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. label Jan 17, 2024
@geospatialem
Copy link
Member

For the design consideration, please refer to #7822 (comment) cc @SkyeSeitz @ashetland

@SkyeSeitz
Copy link

This effort will be investigated in the dark mode color considerations of issue #3122 👍🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. design Issues that need design consultation prior to development. needs triage Planning workflow - pending design/dev review.
Projects
None yet
Development

No branches or pull requests

4 participants