Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form - Ensure active user interface components have sufficient contrast - (2036570491) #7847

Closed
dqateam opened this issue Sep 19, 2023 · 6 comments
Labels
0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. design Issues that need design consultation prior to development. estimate - 3 A day or two of work, likely requires updates to tests. needs triage Planning workflow - pending design/dev review.

Comments

@dqateam
Copy link
Collaborator

dqateam commented Sep 19, 2023

Violation:

Ensure active user interface components have sufficient contrast

image

WCAG Reference:

Severity:

6

Media Type:

Color and Contrast


Areas for Remediation:

  • Title: Form - Ensure active user interface components have sufficient contrast - (2036570491)
  • Module: Form
    Issue
    There are form fields with a contrast ratio below 3.00:1.

Foreground: #949494
Background: #F8F8F8
Contrast ratio: 2.86:1

Examples of this user interface component include:

  • Your name
  • Will you be using Calcite components in an upcoming project?
  • What is your favorite component(s)?
  • Configuration
  • Accessibility
  • Ease of use

User Impact
Users with low vision will have difficulty identifying this content.

Code Reference

<input aria-label="Your name" class="" value="" enterkeyhint="" inputmode="" placeholder="John Doe" type="text">

Suggestion
Ensure active user interface components have sufficient contrast. The required minimum contrast ratio is 3.00:1.

Common examples of qualifying components include text field borders, checkmarks for checkboxes, fillings for radio buttons, focus indicators, and icon-only controls.

For borders, the "adjacent color" can be the color that touches the outside of the border or the color that touches the inside of the border. Contrast with both is not required.

Disabled controls that cannot be navigated to with the keyboard are exempt from this requirement.

Refer to the Accessible Color Picker extension or Color Contrast Checker site for assistance: https://www.accessibility.dev/


Additional Resources:

  • Report Source: Product accessibility evaluation conducted on the Calcite Design System in August, 2022.
@dqateam dqateam added 0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Sep 19, 2023
@macandcheese
Copy link
Contributor

Hard to tell the issue here. Is the referenced code from shadow root of calcite-input or just a native one? Our calcite-input should be using the correct input-border variable.

@geospatialem
Copy link
Member

geospatialem commented Oct 26, 2023

This looks to relate to the --calcite-ui-background in:

  1. calcite-mode-light (#F8F8F8) with the outline of the input (#949494), where the contrast ratio is 2.85:1.
  2. calcite-mode-dark (#353535) with the outline of the input (#757575), where the contrast ratio is 2.66:1

calcite-mode-light:

image
image

calcite-mode-dark:

image
image

@geospatialem
Copy link
Member

geospatialem commented Jan 8, 2024

Added context to the above epic, #7822.

Impacts the following components* using the --calcite-color-border-input CSS prop and border-color-input Tailwind util for:

  • checkbox
  • combobox
  • input
  • input-date-picker
  • input-number
  • input-text
  • radio-button
  • segmented-control
  • select
  • slider
  • switch
  • text-area

* Does not include composite components used as supporting children, such as input-time-zone or color-picker.

@geospatialem geospatialem added the estimate - 3 A day or two of work, likely requires updates to tests. label Jan 8, 2024
@geospatialem
Copy link
Member

For design efforts, would like to confirm the above recommendation is in alignment across the design system and determine if any changes are needed with Figma prior to proceeding. cc @SkyeSeitz @ashetland

@SkyeSeitz
Copy link

Thanks, @geospatialem! The mentioned input.border passes on the expected foreground-1 surface. If higher contrast is needed on a different surface, the token is available for customization.

@geospatialem
Copy link
Member

Closing based on Skye's comment above.

@geospatialem geospatialem closed this as not planned Won't fix, can't repro, duplicate, stale Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. design Issues that need design consultation prior to development. estimate - 3 A day or two of work, likely requires updates to tests. needs triage Planning workflow - pending design/dev review.
Projects
None yet
Development

No branches or pull requests

4 participants