Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit event names emitted by openCloseComponent util #9513

Open
1 of 5 tasks
Elijbet opened this issue Jun 4, 2024 · 0 comments
Open
1 of 5 tasks

Revisit event names emitted by openCloseComponent util #9513

Elijbet opened this issue Jun 4, 2024 · 0 comments
Assignees
Labels
1 - assigned Issues that are assigned to a sprint and a team member. calcite-components Issues specific to the @esri/calcite-components package. estimate - 8 Requires input from team, consider smaller steps. p - high Issue should be addressed in the current milestone, impacts component or core functionality refactor Issues tied to code that needs to be significantly reworked.

Comments

@Elijbet
Copy link
Contributor

Elijbet commented Jun 4, 2024

Description

Revisit event names emitted by openCloseComponent util.

Emitting open/close events when expanded/collapsed might be misleading and won't work for cases where we have both props (e.g., list, action-menu).

As an alternative consider open/close (or some other name) as the main events and add a prop to indicate which property it relates to.

Consider expanding the scope of openCloseComponent to something like transitionEventComponent that would handle multiple types of transitions from open/expanded and whatever else may need it.

Blocked issues: #6017, #4544, #11227

Proposed Advantages

More clarity and accuracy in event naming, and compatibility with cases where both expanded/collapsed and open/closed props are present.

Which Component

openCloseComponent util

Relevant Info

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components
@Elijbet Elijbet added refactor Issues tied to code that needs to be significantly reworked. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jun 4, 2024
@github-actions github-actions bot added the calcite-components Issues specific to the @esri/calcite-components package. label Jun 4, 2024
@Elijbet Elijbet self-assigned this Jul 25, 2024
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. p - high Issue should be addressed in the current milestone, impacts component or core functionality estimate - 5 A few days of work, definitely requires updates to tests. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jul 29, 2024
@geospatialem geospatialem added estimate - 8 Requires input from team, consider smaller steps. and removed estimate - 5 A few days of work, definitely requires updates to tests. labels Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - assigned Issues that are assigned to a sprint and a team member. calcite-components Issues specific to the @esri/calcite-components package. estimate - 8 Requires input from team, consider smaller steps. p - high Issue should be addressed in the current milestone, impacts component or core functionality refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Development

No branches or pull requests

2 participants