-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Open/Close events should be publicly exposed for top-level components #4544
Comments
It seems the originating issue for this has been addressed (making combobox open/close events public). There are other components that could implement
Not sure if we want to address those in a separate PR or repurpose this one. We may also need to tackle #5074 along with this issue. |
Do we have an issue to add these kind of events for |
I'll add those to this issue as well. Items that use
And
|
In order to make components with |
Blocked by the efforts of #9513 |
Description
Related Issue: #2256
Summary
Follow-up issue: Open/Close events should be publicly exposed, as these might be useful for users at some point. Especially for a top-level component that isn't emitting this event for another Calcite component to listen for. In that case, just ensure it does not have the @internal label or Internal prefix and is documented.
Proposed Advantages
Users might need control over these.
Which Component
Based on the comment below:
The originating issue for this has been addressed (making combobox open/close events public). Other components could implement OpenCloseComponent with associated events:
open
prop:expanded
prop:closed
prop:collapsed
prop:We may also need to tackle #5074 along with this issue.
The text was updated successfully, but these errors were encountered: