refactor(modal, sheet, OpenCloseComponent): adopt openProp to replace open/opened props in the interface
#8082
+4
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vention for opened prop
github-actions
bot
added
the
refactor
Elijbet
added
the
skip visual snapshots
Citation game is on point. 🔥 PR-wise, I think I may have miscommunicated something. What I meant was to update to:
Note that this does not include renaming the |
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
I'll include the steps mentioned in the PR description. |
Elijbet
changed the title
opened propopenProp to the OpenCloseComponent interface to specify the opening/closing control prop to phase out open/opened props.
Elijbet
added
impact - p3 - not time sensitive
Elijbet
changed the title
openProp to the OpenCloseComponent interface to specify the opening/closing control prop to phase out open/opened props.openProp to replace open/opened props in the OpenCloseComponent interface
Elijbet
changed the title
openProp to replace open/opened props in the OpenCloseComponent interface openProp to replace open/opened props in the interface
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
github-actions
bot
removed
the
Stale
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #4544
Summary
Introduces
openPropproperty on theOpenCloseComponentinterface which specifies the name of the prop that controls opening/closing (similar to openTransitionProp). The new property phases outopenandopenedprops.Picking up 2 related comments:
#7680 (comment)
#7685 (comment)