Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tabs] Different visual appearance for bordered in layout="top"/"bottom" #9647

Open
2 of 6 tasks
macandcheese opened this issue Jun 20, 2024 · 1 comment
Open
2 of 6 tasks

[Tabs] Different visual appearance for bordered in layout="top"/"bottom" #9647

macandcheese opened this issue Jun 20, 2024 · 1 comment
Labels
2 - in development Issues that are actively being worked on. blocked This issue is blocked by another issue. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
Stalled

Comments

@macandcheese
Copy link
Contributor

Check existing issues

Actual Behavior

There is inconsistent visual display of the Tabs component when using the bordered appearance in the layout positions:
Screenshot 2024-06-20 at 9 53 22 AM

Screenshot 2024-06-20 at 9 53 16 AM

Expected Behavior

I'd expect the same UI treatment for bordered across layout positions.

Reproduction Sample

https://codepen.io/mac_and_cheese/pen/vYwRXdp?editors=1000

Reproduction Steps

  1. Open Codepen
  2. View difference

Reproduction Version

2.9

Relevant Info

No response

Regression?

No response

Priority impact

impact - p3 - not time sensitive

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@macandcheese macandcheese added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jun 20, 2024
@macandcheese macandcheese added this to the 2024-06-25 - Jun Release milestone Jun 20, 2024
@macandcheese macandcheese added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Jun 20, 2024
@macandcheese macandcheese self-assigned this Jun 20, 2024
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Jun 20, 2024
@macandcheese macandcheese added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 2 Small fix or update, may require updates to tests. and removed needs triage Planning workflow - pending design/dev review. labels Jun 20, 2024
@geospatialem geospatialem added the blocked This issue is blocked by another issue. label Jul 29, 2024
@geospatialem
Copy link
Member

geospatialem commented Jul 29, 2024 •
edited
Loading

Blocked by #2721. If a breaking change isn't needed on the restructure, we can revisit prior to November, otherwise we're anticipating the work to start in December.

@geospatialem geospatialem mentioned this issue Jul 29, 2024
Open
@macandcheese macandcheese removed their assignment Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 - in development Issues that are actively being worked on. blocked This issue is blocked by another issue. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
Stalled
Development

No branches or pull requests
2 participants
@macandcheese @geospatialem