-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Simplify calcite-tabs structure #2721
Comments
@geospatialem I labeled this one a breaking change since it will restructure the tabs and probably make some events/properties no longer necessary. |
This will likely be a refactor in Figma as well. |
@jcfranco anything we can do to move this along? Because the component now has built in |
The above blocks the effort of #9647. Depending on the above spike, will dictate the timing of carrying out, either for December (if the above is indeed a breaking change), or earlier (if a non-breaking change is carried out). |
Moving the spike effort post-3.0 for additional considerations, and if we can pursue a non-breaking change to the above in 2025, or if we should consider for |
Description
The current structure for tabs is a bit cumbersome for simple use cases:
The following structure is a proposal to simplify its usage and hopefully covers most basic use cases:
To preserve existing tab-customization use cases, the following approaches could work:
Adding "title" slot to allow customizing
tab
's title:Adding
icon-start
/icon-end
props totab
to quickly add an icon:The first option seems the most flexible, as it would allow users to entirely customize the tab, including interactions (e.g., adding a close button that dismisses the tab when pressed).
Blocked issues: #9647, #10122, #6639
Acceptance Criteria
calcite-tabs
follows the structure described above.Relevant Info
From #1258 (comment)
Which Component
calcite-tabs
Example Use Case
See example snippets.
The text was updated successfully, but these errors were encountered: