feat(input-time-picker): add hour-format property #10059
Conversation
…lharper/4756-time-picker-24-hour-support
… value of 0:0:0 resulted in a clearing of the value
… where we need to set the localized input value. Also fixed a place where localized meridiem wasn't being set properly.
…we can determine hourcycle from just the locale. Refactored input-time-picker to match time-picker in how it updates locale state when it changes, including setting a default hourCycle when one is not provided.
…rd to something better
… on hourCycle. Not perfectly working, but we'll need this to get to the next step which is to parse both 12 and 24 hour formats. Fixing Arabic locale time format overrides to match ICU.
…e working regardless of hourCycle!
…ater in the e2e typing tests
…alue to nil. Also adding comprehensive locale typing tests, need to expand a bit more and fix a few locales still
…ult locales by correcting the regex to capture whitespace characters on either side of the meridiem tokens in the time format string
…l supported locales to test that render meridiem to the left of the time value
…t seem to like a lot of the localized meridiem formats, so we may want to ship this with the caveat that it might not work just right for all locales
…s and mk decimal separators in Chromium
…renaming some variables in 12-hour test to make them more meaningful
…lharper/4756-time-picker-24-hour-support
… element. Attempt to see if this resolves random unstable test failures
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
eriklharper
removed
the
Stale
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
github-actions
bot
removed
the
Stale
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
packages/calcite-components/src/components/input-time-picker/input-time-picker.tsx
Show resolved
Hide resolved
| localizedTwentyFourHourMeridiems.has(this.effectiveLocale) && | ||
| effectiveHourFormat === "12" | ||
| ) { | ||
| const localizedAM = localizedTwentyFourHourMeridiems.get(this.effectiveLocale).am; |
There was a problem hiding this comment.
Gotcha. Based on how often localizing logic takes place, we should look into refactoring to improve performance (e.g., reusing/minimizing objects across internal localization updates). It would benefit both localizing and delocalizing paths. We can do this in a follow-up refactor issue if local perf testing looks good.
github-actions
bot
removed
the
Stale
|
@eriklharper Per #10997 (comment), I'm converting this to a draft to avoid reviewer confusion. |
|
Closing in favor of #10997 |
Related Issue: #4756
Summary
This PR exposes a new
hour-formatproperty toinput-time-pickerandtime-pickerthat overrides the locale's defaulthourCyclesetting, allowing a 12-hour locale to be formatted in 24-hour time and vice versa. Confirmed with the i18n team that the bulgarianч.character (abbreviation for "hours") should not display for short and medium time formats.