Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tabs, tab, tab-title, tab-nav): update component tokens #10579

Draft
wants to merge 2 commits into
base: jcfranco/7180-add-tabs-component-tokens
Choose a base branch
from
+217 −221
Draft

feat(tabs, tab, tab-title, tab-nav): update component tokens #10579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9bfd4e4
feat(tabs, tab, tab-title, tab-nav): update component tokens
alisonailea Oct 22, 2024
c325e48
docs(tabs): update “the” to “specifies” to follow conventions
alisonailea Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions packages/calcite-components/.stylelintrc.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,7 @@
// @ts-check

// ⚠️ AUTO-GENERATED CODE - DO NOT EDIT
const customFunctions = [
"get-trailing-text-input-padding",
"medium-modular-scale",
"modular-scale",
"scale-duration",
"small-modular-scale"
];
const customFunctions = [];
// ⚠️ END OF AUTO-GENERATED CODE

const scssPatternRules = [
Expand Down
46 changes: 24 additions & 22 deletions packages/calcite-components/src/components/tab-nav/tab-nav.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,24 @@
/**
* CSS Custom Properties
*
* These properties can be overridden using the component's tag as selector.
*
* @prop --calcite-tab-background-color: Specifies background color of the component.
* @prop --calcite-tab-border-color: Specifies border color of the component. Used for "bordered" tabs.
* @prop --calcite-tab-text-color: Specifies the icon and text color of the component.
*/

:host {
--calcite-internal-tab-nav-gradient-start-side: left;
--calcite-internal-tab-nav-gradient-end-side: right;

--calcite-internal-tab-nav-button-background-color: var(--calcite-color-transparent);
--calcite-internal-tab-nav-button-border-color: var(--calcite-color-transparent);

@apply relative flex;
}

:host([bordered]) {
--calcite-internal-tab-nav-button-background-color: var(--calcite-internal-tabs-background-color);
--calcite-internal-tab-nav-button-border-color: var(--calcite-internal-tabs-border-color);
.container {
background-color: var(--calcite-tab-background-color, var(--calcite-color-foreground-1));
}
}

.scale-s {
Expand Down Expand Up @@ -135,27 +143,20 @@ $last-mask-color-stop-position: 51%; // we go beyond the half point to ensure th
@apply absolute bottom-0 top-0;

calcite-button {
--calcite-internal-tab-icon-color: var(--calcite-tab-icon-color, var(--calcite-color-text-3));
--calcite-button-text-color: var(--calcite-tab-text-color, var(--calcite-color-text-3));
--calcite-button-background-color: var(--calcite-color-transparent);
--calcite-button-border-color: var(--calcite-tab-border-color, var(--calcite-color-border-1));

--calcite-button-background-color: var(
--calcite-internal-tab-nav-button-background-color,
var(--calcite-color-transparent)
);
--calcite-button-border-color: var(--calcite-internal-tab-nav-button-border-color);
--calcite-button-icon-color: var(--calcite-internal-tab-icon-color);
--calcite-button-shadow-color: var(--calcite-color-transparent);
--calcite-offset-invert-focus: 1;

block-size: var(--calcite-container-size-content-fluid);

&:active,
&:hover {
--calcite-button-background-color: var(
--calcite-internal-tab-background-color-hover,
var(--calcite-color-transparent-hover)
);
--calcite-button-border-color: var(--calcite-internal-tab-nav-button-border-color);
--calcite-button-icon-color: var(--calcite-internal-tab-icon-color);
&:hover &:focus {
--calcite-button-background-color: var(--calcite-color-transparent-hover);
}

&:active {
--calcite-button-background-color: var(--calcite-color-transparent-press);
}
}
}
Expand All @@ -173,8 +174,9 @@ $last-mask-color-stop-position: 51%; // we go beyond the half point to ensure th
:host(:not([bordered])) {
.scroll-button-container--backward,
.scroll-button-container--forward {
// Scroll arrow separators
&::before {
background-color: var(--calcite-internal-tabs-border-color);
background-color: var(--calcite-tab-border-color, var(--calcite-color-border-1));
opacity: $calcite-opacity-50;
content: "";
inline-size: var(--calcite-border-width-sm);
Expand Down
Loading