Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: migrate to Lumina #10696

Closed
wants to merge 54 commits into from
Closed

refactor!: migrate to Lumina #10696

wants to merge 54 commits into from

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Nov 5, 2024

Note: This is set up for updated testing. The lumina branch will be replaced by this one.

Related Issue: #10310, #10481, #10399, #10405, #10491, #10434, #10495

Noteworthy changes

  • React deps bumped to v18
  • components are now Lit-based
  • removed @storybook/test and @storybook/addon-interactions as these were not being actively used

BREAKING CHANGE:

  • removed the following @esri/eslint-plugin-calcite-components rules as they are no longer valid:
    • ban-props-on-host
    • enforce-ref-last-prop
    • require-event-emitter-type

jcfranco and others added 15 commits November 4, 2024 08:40
@jcfranco
refactor!: migrate to Lumina
41f6334
@jcfranco
updated pass
0a76313
@jcfranco
bump TS + add @lit/react
334557a
@jcfranco
dedupe deps
e834bbb
@jcfranco
move deps to root
ccfd21a
@jcfranco
drop @stencil-community/eslint-plugin and remove rules
7f9a417
@jcfranco
fix icons build
4534f06
@jcfranco
sync all lumina deps
e1656f3
@jcfranco
remove ignore lines for @stencil-community/eslint-plugin rules
5c44ccb
@jcfranco
make messages internal
0805f61
@jcfranco
drop unnecessary react-wrapper patch
d5f19d1
@benelan @calcite-admin @renovate
build(deps): cherry pick updates from dev (#10694)
7ccd607 
**Related Issue:** #10482

## Summary

- **build: update browserslist db (#10629)**
- **docs(angular): update example to use custom elements directly
(#10686)**
- **build(deps): update dependency @floating-ui/dom to v1.6.12
(#10681)**
- **build(deps): update dependency @cspell/eslint-plugin to v8.15.6
(#10680)**
- **build(deps): update dependency chokidar to v4 (#10643)**

---------

Co-authored-by: Calcite Admin <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@jcfranco
remove Stencil logic from custom ESLint rules
065951c
@jcfranco
refactor(table): refactor internals to work around HTML parser issue (#…
0979376 
…10649)

**Related Issue:** #10495

## Summary

Split up table rendering to bypass HTML parser corrections that would
break functionality and styling.
@jcfranco
fix scripts and update storybook to leverage vite build
b3ef2f7
@jcfranco jcfranco requested a review from benelan as a code owner November 5, 2024 22:56
@jcfranco jcfranco marked this pull request as draft November 5, 2024 22:56
@jcfranco jcfranco marked this pull request as ready for review November 5, 2024 23:07
@jcfranco jcfranco marked this pull request as draft November 5, 2024 23:07
@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Nov 5, 2024
@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Nov 5, 2024
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Nov 6, 2024
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Nov 6, 2024
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Nov 6, 2024
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Nov 7, 2024
@jcfranco
Copy link
Member Author

jcfranco commented Nov 7, 2024

The lumina branch is now updated. Please switch any PR base branches to it, and refer to this PR for ongoing updates.

@jcfranco jcfranco closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benelan benelan Awaiting requested review from benelan benelan is a code owner

Assignees

@jcfranco jcfranco

Labels
pr ready for visual snapshots Adding this label will run visual snapshot testing. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcfranco @benelan