Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(combobox): fix sporadic change event emitted on initialization #10952

Merged
merged 3 commits into from
Dec 4, 2024
Merged

fix(combobox): fix sporadic change event emitted on initialization #10952

merged 3 commits into from
Dec 4, 2024

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Dec 3, 2024 •
edited
Loading

Related Issue: #10731

Summary

Tweaks initialization logic to prevent extraneous change event that happened after #10310.

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Dec 3, 2024
@jcfranco jcfranco added no changelog entry Use the commit override to avoid a changelog entry pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Dec 3, 2024
@jcfranco jcfranco marked this pull request as ready for review December 3, 2024 08:07
driskull
driskull approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Dec 3, 2024
@jcfranco jcfranco removed the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Dec 3, 2024
@jcfranco jcfranco mentioned this pull request Dec 3, 2024
Open
5 tasks
@jcfranco jcfranco merged commit e84ed58 into dev Dec 4, 2024
10 checks passed
@jcfranco jcfranco deleted the jcfranco/fix-combobox-init-change-event branch December 4, 2024 00:28
@github-actions github-actions bot added this to the 2024-12-17 - Dec Milestone milestone Dec 4, 2024
@eriklharper
Copy link
Contributor

I kinda feel like we should write a test utility that each component can use to ensure no change events fire on initial load...

@jcfranco
Copy link
Member Author

@eriklharper I like that idea. Maybe we can include it in #11080.

@jcfranco jcfranco mentioned this pull request Jan 11, 2025
Merged
jcfranco added a commit that referenced this pull request Jan 11, 2025
@jcfranco
perf(combobox): fix initialization performance regression (#11265)
a255c5a 
**Related Issue:** #10731  

## Summary  

#10952 increased the
frequency of `combobox`'s item-updating logic.

This improves performance by:  

* reducing the number of initial item update calls  
* debouncing the item update function to the next tick
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull approved these changes

@macandcheese macandcheese Awaiting requested review from macandcheese

Assignees

@jcfranco jcfranco

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. no changelog entry Use the commit override to avoid a changelog entry skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
2024-12-17 - Dec Milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcfranco @eriklharper @driskull