Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(inline-editable): fix cancel workflow #11046

Merged
merged 1 commit into from
Dec 13, 2024
Merged

fix(inline-editable): fix cancel workflow #11046

merged 1 commit into from
Dec 13, 2024

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Dec 13, 2024 •
edited
Loading

Related Issue: #10731

Summary

Fixes issue that prevented canceling an edit session and restoring the input.

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Dec 13, 2024
@jcfranco jcfranco added no changelog entry Use the commit override to avoid a changelog entry skip visual snapshots Pull requests that do not need visual regression testing. labels Dec 13, 2024
@jcfranco jcfranco requested a review from driskull December 13, 2024 01:07
driskull
driskull approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@jcfranco jcfranco merged commit bc65eae into dev Dec 13, 2024
20 checks passed
@jcfranco jcfranco deleted the jcfranco/fix-inline-editable-cancel-workflow branch December 13, 2024 17:37
@github-actions github-actions bot added this to the 2024-12-17 - Dec Milestone milestone Dec 13, 2024
benelan pushed a commit that referenced this pull request Dec 14, 2024
@jcfranco @benelan
fix(inline-editable): fix cancel workflow (#11046)
32724ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull approved these changes

Assignees

@jcfranco jcfranco

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. no changelog entry Use the commit override to avoid a changelog entry skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
2024-12-17 - Dec Milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcfranco @driskull