fix(list): fix issue where last call to debounced update filter logic would override args from previous calls #11064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… would override args from previous calls
github-actions
bot
added
the
bug
jcfranco
added
no changelog entry
benelan
approved these changes
Dec 16, 2024
|
@benelan Good idea. I'll update this PR if I can reproduce consistently. |
jcfranco
added
the
skip visual snapshots
jcfranco
removed
the
pr ready for visual snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #10731
Summary
Adds internal flag to determine if filter should be performed. Similar to
ad054fd(#10482), this is needed because subsequent calls afterupdateListItem({ performFilter: true })would take precedence due to howlodash#debounceworks:BEGIN_COMMIT_OVERRIDE
END_COMMIT_OVERRIDE