Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(storybook): update calcite-fonts CDN URL #11069

Closed
wants to merge 1 commit into from
Closed

chore(storybook): update calcite-fonts CDN URL #11069

wants to merge 1 commit into from

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Dec 16, 2024 •
edited
Loading

Related Issue: N/A

Summary

✨🔠✨

@jcfranco jcfranco requested a review from benelan as a code owner December 16, 2024 17:28
@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Dec 16, 2024
@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Dec 16, 2024
anveshmekala
anveshmekala approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@anveshmekala anveshmekala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcfranco
Copy link
Member Author

@SkyeSeitz @ashetland This will need a full review since this impacts a lot of screenshots (~600). This is not urgent, so I'll defer to whatever timeline you think is best. 🤜💥🤛

@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Dec 26, 2024
benelan
benelan approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@benelan benelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions github-actions bot removed the Stale Issues or pull requests that have not had recent activity. label Jan 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Jan 24, 2025
@jcfranco
Copy link
Member Author

Closing this for now as calcite-fonts v2 impacts layout, and the line-height workaround isn’t precise. We’ll revisit when the layout is unaffected.

@jcfranco jcfranco closed this Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benelan benelan benelan approved these changes

@anveshmekala anveshmekala anveshmekala approved these changes

@eriklharper eriklharper Awaiting requested review from eriklharper

Assignees

@jcfranco jcfranco

Labels
chore Issues with changes that don't modify src or test files. pr ready for visual snapshots Adding this label will run visual snapshot testing. Stale Issues or pull requests that have not had recent activity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcfranco @benelan @anveshmekala