fix(accordion-item): stretch slotted actions only #11082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfranco
added
the
no changelog entry
github-actions
bot
added
the
bug
jcfranco
added
the
pr ready for visual snapshots
|
Alternatively, we could also tweak |
jcfranco
added
pr ready for visual snapshots
This could be a nice fallback for all non-action elements. A user can always slot a div, unset styles - but I think center align is a more expected default than align-top? |
|
@macandcheese Fortunately, slotted, non-action items are already centered, so no further changes needed! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #10731
Summary
This avoids unintentionally styling other actionable components and offers more flexibility.
Note: this changes styles to use explicit selectors instead of universal ones to improve maintainability.