Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(input, input-text, input-number): restore handling of autofocus global attribute #11118

Merged
merged 2 commits into from
Dec 21, 2024
Merged

fix(input, input-text, input-number): restore handling of autofocus global attribute #11118

merged 2 commits into from
Dec 21, 2024

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Dec 20, 2024 •
edited
Loading

Related Issue: #10731

Summary

Fixes an issue caused by #10310, where autofocus was no longer used within rendering.

@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Dec 20, 2024
@jcfranco jcfranco force-pushed the jcfranco/restore-autofocus-toggling-at-runtime branch from 9398bbb to c9fa64a Compare December 20, 2024 08:09
@jcfranco jcfranco changed the title feat(autocomplete, input, input-number, input-text): improve types fix(input, input-text, input-number): restore handling of autofocus global attribute Dec 20, 2024
@jcfranco jcfranco added no changelog entry Use the commit override to avoid a changelog entry skip visual snapshots Pull requests that do not need visual regression testing. labels Dec 20, 2024
@jcfranco jcfranco requested a review from driskull December 20, 2024 21:38
driskull
driskull approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice catch 🐟

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Dec 21, 2024
@jcfranco jcfranco merged commit af32894 into dev Dec 21, 2024
10 checks passed
@jcfranco jcfranco deleted the jcfranco/restore-autofocus-toggling-at-runtime branch December 21, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull approved these changes

Assignees

@jcfranco jcfranco

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. enhancement Issues tied to a new feature or request. no changelog entry Use the commit override to avoid a changelog entry skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
2025-02-06 - 3.0.0 Feb Breaking Chang...
Development

Successfully merging this pull request may close these issues.
2 participants
@jcfranco @driskull