-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rating): add component tokens #11150
Changes from 5 commits
0b6dfad
f92268f
291ca3e
940ef9a
8d55d3a
556d50d
ef207ca
6cc7075
d3f03ee
fe053ff
419ca27
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,12 @@ | |
* | ||
* These properties can be overridden using the component's tag as selector. | ||
* | ||
* @prop --calcite-rating-spacing-unit: The amount of left and right margin spacing between each rating star. | ||
* @prop --calcite-rating-spacing-unit: Specifies the amount of left and right margin spacing between each item. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. deprecate in favor of |
||
* @prop --calcite-rating-selected-color-hover: Specifies the component's item color when hovered or selected. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
* @prop --calcite-rating-color: Specifies the component's item color. | ||
* @prop --calcite-rating-average-color: Specifies the component's item color when average is set. | ||
* @prop --calcite-rating-average-text-color: Specifies the component's average text color. | ||
* @prop --calcite-rating-count-text-color: Specifies the component's count text color. | ||
*/ | ||
|
||
:host { | ||
|
@@ -15,17 +20,17 @@ | |
|
||
:host([scale="s"]) { | ||
@apply h-6; | ||
--calcite-rating-spacing-unit: theme("spacing.1"); | ||
--spacing: theme("spacing.1"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. tokens should not be assigned in the component unless they are tagged with |
||
} | ||
|
||
:host([scale="m"]) { | ||
@apply h-8; | ||
--calcite-rating-spacing-unit: theme("spacing.2"); | ||
--spacing: theme("spacing.2"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. tokens should not be assigned in the component unless they are tagged with |
||
} | ||
|
||
:host([scale="l"]) { | ||
@apply h-11; | ||
--calcite-rating-spacing-unit: theme("spacing.3"); | ||
--spacing: theme("spacing.3"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. tokens should not be assigned in the component unless they are tagged with |
||
} | ||
|
||
:host([read-only]) { | ||
|
@@ -38,7 +43,7 @@ | |
border-width: 0; | ||
padding: 0; | ||
align-items: center; | ||
gap: var(--calcite-rating-spacing-unit); | ||
gap: var(--calcite-rating-spacing-unit, var(--spacing)); | ||
} | ||
|
||
.wrapper { | ||
|
@@ -51,20 +56,20 @@ | |
display: flex; | ||
flex-direction: column; | ||
cursor: pointer; | ||
color: theme("borderColor.color.input"); | ||
color: var(--calcite-rating-color, theme("borderColor.color.input")); | ||
&:focus { | ||
@apply focus-outset; | ||
} | ||
} | ||
|
||
.average, | ||
.fraction { | ||
color: theme("colors.warning"); | ||
color: var(--calcite-rating-average-color, theme("colors.warning")); | ||
} | ||
|
||
.hovered, | ||
.selected { | ||
color: theme("colors.brand"); | ||
color: var(--calcite-rating-selected-color-hover, theme("colors.brand")); | ||
} | ||
|
||
.fraction { | ||
|
@@ -84,13 +89,14 @@ calcite-chip { | |
|
||
.number--average { | ||
font-weight: bold; | ||
color: var(--calcite-rating-average-text-color); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what is the purpose of this token? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
} | ||
|
||
.number--count { | ||
color: var(--calcite-color-text-2); | ||
color: var(--calcite-rating-count-text-color, var(--calcite-color-text-2)); | ||
font-style: italic; | ||
&:not(:first-child) { | ||
margin-inline-start: var(--calcite-rating-spacing-unit); | ||
margin-inline-start: var(--calcite-rating-spacing-unit, var(--spacing)); | ||
} | ||
} | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,7 @@ | ||
export const CSS = { | ||
star: "star", | ||
}; | ||
|
||
export const IDS = { | ||
validationMessage: "validationMessage", | ||
}; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
import { html } from "../../support/formatting"; | ||
|
||
export const ratingTokens = { | ||
calciteRatingSpacingUnit: "", | ||
calciteRatingHoverSelectedColor: "", | ||
calciteRatingIdleUnselectedColor: "", | ||
calciteRatingAverageColor: "", | ||
calciteRatingAverageTextColor: "", | ||
calciteRatingCountColor: "", | ||
}; | ||
|
||
export const rating = html`<calcite-rating></calcite-rating>`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add tests for the other vars?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added tests for the other tokens. I'm having issues testing
--calcite-rating-spacing
, could you please take a look?cc @driskull @alisonailea