fix(list): drag event properties newIndex and oldIndex should only reflect list item indexes
#11402
+92
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
driskull
changed the title
newIndex and oldIndex within the event calciteListOrderChangenewIndex and oldIndex within the event calciteListOrderChange should only consider list items
driskull
changed the title
newIndex and oldIndex within the event calciteListOrderChange should only consider list itemscalciteListOrderChange event properties newIndex and oldIndex should not be affected by slotted content
driskull
changed the title
calciteListOrderChange event properties newIndex and oldIndex should not be affected by slotted contentnewIndex and oldIndex should not be affected by slotted content
driskull
changed the title
newIndex and oldIndex should not be affected by slotted contentnewIndex and oldIndex should only reflect list item indexes
eriklharper
reviewed
Jan 29, 2025
Comment on lines
+1488
to
+1489
| <calcite-tooltip label="scary tooltip" reference-element="filter-action-test" | ||
| >Mind if I offset your index?</calcite-tooltip |
eriklharper
approved these changes
Jan 29, 2025
Seems like its been there for quite a while |
driskull
added
the
pr ready for visual snapshots
github-actions
bot
added this to the 2025-02-06 - 3.0.0 Feb Breaking Change Release milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #11397
Summary
oldDraggableIndexandnewDraggableIndexfrom https://github.com/SortableJS/Sortable?tab=readme-ov-file#event-object-demo in order to only track the relevant indexes of draggable items via mouse.newIndex/oldIndex.