-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: release main #11500
chore: release main #11500
Conversation
ff8495c
to
14b5e5d
Compare
c30a4d8
to
e9d8028
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some breaking change details did not make it into the changelog generated by release-please due to blank lines separating details from the BREAKING CHANGE:
footer(s). I fixed a few obvious ones and added comments (see below) to some others.
Can someone else also proof read the changelog diffs before we message the release out to our users? Any changes/additions to the changelog can be done in follow up PRs. Thanks!
calcite-spacing-fixed-xs: 6px; // deprecated | ||
calcite-spacing-fixed-xxl: 20px; // deprecated | ||
calcite-spacing-fixed-xxs: 4px; // deprecated | ||
calcite-spacing-fixed-xxxl: 32px; // deprecated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of the sections from the tokens' BREAKING CHANGES
to here ended up in the v3 changelog generated by release-please. If they should be there, please create a follow-up PR. cc @alisonailea
- **checkbox:** Removes the deprecated `guid` property from `calcite-checkbox`. | ||
|
||
Developers may need to replace `calcite-checkbox`'s "guid" property with a unique "id" property. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These "Developers will need" and "Developers may need" lines did not make it into the release-please changelog for v3. Please create a followup PR if necessary
This release is too large to preview in the pull request body. View the full release notes here: https://github.com/Esri/calcite-design-system/blob/release-please--branches--main--release-notes/release-notes.md --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Ben Elan <[email protected]>
This release is too large to preview in the pull request body. View the full release notes here: https://github.com/Esri/calcite-design-system/blob/release-please--branches--main--release-notes/release-notes.md --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Ben Elan <[email protected]>
This release is too large to preview in the pull request body. View the full release notes here: https://github.com/Esri/calcite-design-system/blob/release-please--branches--main--release-notes/release-notes.md