Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release main #11500

Merged
merged 3 commits into from
Feb 8, 2025
Merged

chore: release main #11500

merged 3 commits into from
Feb 8, 2025

Conversation

calcite-admin
Copy link
Contributor

@calcite-admin calcite-admin commented Feb 8, 2025

This release is too large to preview in the pull request body. View the full release notes here: https://github.com/Esri/calcite-design-system/blob/release-please--branches--main--release-notes/release-notes.md

@calcite-admin calcite-admin added the autorelease: pending Pull request created by release-please which will deploy to latest when merged label Feb 8, 2025
@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Feb 8, 2025
@calcite-admin calcite-admin force-pushed the release-please--branches--main branch from ff8495c to 14b5e5d Compare February 8, 2025 03:10
@benelan benelan marked this pull request as ready for review February 8, 2025 03:14
@calcite-admin calcite-admin force-pushed the release-please--branches--main branch from c30a4d8 to e9d8028 Compare February 8, 2025 03:34
Copy link
Member

@benelan benelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some breaking change details did not make it into the changelog generated by release-please due to blank lines separating details from the BREAKING CHANGE: footer(s). I fixed a few obvious ones and added comments (see below) to some others.

Can someone else also proof read the changelog diffs before we message the release out to our users? Any changes/additions to the changelog can be done in follow up PRs. Thanks!

cc @jcfranco @geospatialem @DitwanP

calcite-spacing-fixed-xs: 6px; // deprecated
calcite-spacing-fixed-xxl: 20px; // deprecated
calcite-spacing-fixed-xxs: 4px; // deprecated
calcite-spacing-fixed-xxxl: 32px; // deprecated
Copy link
Member

@benelan benelan Feb 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of the sections from the tokens' BREAKING CHANGES to here ended up in the v3 changelog generated by release-please. If they should be there, please create a follow-up PR. cc @alisonailea

- **checkbox:** Removes the deprecated `guid` property from `calcite-checkbox`.

Developers may need to replace `calcite-checkbox`'s "guid" property with a unique "id" property.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These "Developers will need" and "Developers may need" lines did not make it into the release-please changelog for v3. Please create a followup PR if necessary

@benelan benelan merged commit e63242f into main Feb 8, 2025
7 checks passed
@benelan benelan deleted the release-please--branches--main branch February 8, 2025 04:14
@github-actions github-actions bot added this to the 2025-02-25 - Feb Milestone milestone Feb 8, 2025
@calcite-admin
Copy link
Contributor Author

@calcite-admin calcite-admin added autorelease: tagged Pull requests created by release-please that were merged and deployed and removed autorelease: pending Pull request created by release-please which will deploy to latest when merged labels Feb 8, 2025
benelan added a commit that referenced this pull request Feb 8, 2025
This release is too large to preview in the pull request body. View the
full release notes here:
https://github.com/Esri/calcite-design-system/blob/release-please--branches--main--release-notes/release-notes.md

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ben Elan <[email protected]>
calcite-admin added a commit that referenced this pull request Feb 8, 2025
This release is too large to preview in the pull request body. View the
full release notes here:
https://github.com/Esri/calcite-design-system/blob/release-please--branches--main--release-notes/release-notes.md

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ben Elan <[email protected]>
@benelan benelan mentioned this pull request Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autorelease: tagged Pull requests created by release-please that were merged and deployed chore Issues with changes that don't modify src or test files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants