refactor(color)!: rename color to color-picker #1613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfranco
added
refactor
|
Looks like the failing test is unrelated. Maybe needs a |
|
weird did that date test change recently? I feel like there is a ton of flakiness lately in the e2e tests... |
|
@driskull Thanks! I'm working on a small PR for tests. I can fix it there. |
|
I don't think it did but yeah they have been flakey. ❄️ 👎 |
|
Yas! |
|
Forgot to rename the events. 🤣 PR coming up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #1437
Summary
This renames the following components:
calcite-color->calcite-color-pickercalcite-color-hex-input->calcite-color-picker-hex-input†calcite-color-swatch->calcite-color-picker-swatch†† renamed to indicate that these are supporting components and not meant to be used standalone. Associated demo pages were dropped too and their readmes are no longer linked from the main story.