feat(input-time-picker, time-picker): add time-picker and input-time-picker components #1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-input-time-picker
…ring to dry up the formatting logic
…et ready for adding a second colon for seconds support
…so that the hit targets for hour and minute are the intended size but retain the offset hover and focus borders based on the design
…d which perfectly centers arrow buttons with numbers but only slightly increases the width of the whole container div to accommodate the colon
…s to recognize the value
…lid supported use case
…ing out in the DOM
…ep warning go away
…ng input blur behavior
…first time after a full page reload
jcfranco
approved these changes
Jun 3, 2021
There was a problem hiding this comment.
Awesome stuff, @eriklharper! Other than a few comments, this looks good to merge!
src/components/calcite-input-time-picker/calcite-input-time-picker.tsx
Outdated
Show resolved
Hide resolved
jcfranco
changed the title
|
@eriklharper you'll have to remove the 'theme' prop stuff in this one |
eriklharper
added
the
3 - installed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #407