Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alert): update autoDimissDuration scales to be quicker. #3803

Conversation

anveshmekala
Copy link
Contributor

Related Issue: #2800

Summary

This allows users to parse time values in autoDismissDuration prop for calcite-alert and default value is set to 5000ms

@github-actions github-actions bot added this to the Sprint 12/20 - 12/31 milestone Dec 28, 2021
@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Dec 28, 2021
@anveshmekala anveshmekala added the breaking change Issues and pull requests with code changes that are not backwards compatible. label Dec 28, 2021
@anveshmekala anveshmekala removed the breaking change Issues and pull requests with code changes that are not backwards compatible. label Dec 30, 2021
@anveshmekala anveshmekala marked this pull request as ready for review December 31, 2021 21:14
@anveshmekala anveshmekala requested a review from a team as a code owner December 31, 2021 21:14
@jcfranco
Copy link
Member

jcfranco commented Jan 6, 2022

Thanks for prototyping this, @anveshmekala. Per the discussion on #2800, we'll be tweaking the named duration values instead. Closing based on this.

@jcfranco jcfranco closed this Jan 6, 2022
@anveshmekala anveshmekala changed the title feat(alert): allow time values in autoDimissDuration feat(alert): update autoDimissDuration scales to be quicker. Jan 6, 2022
@anveshmekala anveshmekala deleted the anveshmekala/2800-alert-allow-time-values-in-dimiss-duration branch May 18, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues tied to a new feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants