Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(conventions): separation of concerns for the internal doc #4295

Merged
merged 4 commits into from
Mar 31, 2022

Conversation

benelan
Copy link
Member

@benelan benelan commented Mar 23, 2022

Related Issue: #3818

Summary

No content was changed or added. This PR is just the initial separation of concerns as we work towards expanding our internal doc to look more like Hub's storybook.
image

And here is ours with these changes:
image

The next step is beefing up our internal doc

@benelan benelan requested a review from a team as a code owner March 23, 2022 22:01
@github-actions github-actions bot added this to the Sprint 03/14 - 03/25 milestone Mar 23, 2022
@benelan benelan changed the title Benelan/separate conventions docs(conventions): separation of concerns for the internal doc Mar 23, 2022
@benelan benelan requested a review from jcfranco March 23, 2022 22:15
@github-actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Mar 31, 2022
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's beautiful

@@ -0,0 +1,6 @@
# Accessability
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed this filename is spelled incorrectly. Should be named Accessibility.md

@benelan benelan requested a review from eriklharper March 31, 2022 16:54
@benelan benelan merged commit e03242d into master Mar 31, 2022
@benelan benelan deleted the benelan/separate-conventions branch March 31, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Issues or pull requests that have not had recent activity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants