-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(contributing, conventions): proofread and add additional info #5228
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice updates - great inclusion of the style guide notes! 💯 A few small considerations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖
📖🤩📖📖📖📖📖🤩📖📖🤩🤩📖📖🤩📖📖📖📖📖🤩📖🤩🤩🤩🤩📖🤩🤩🤩🤩📖🤩📖
📖🤩📖📖📖📖📖🤩📖🤩📖📖🤩📖🤩📖📖📖📖📖🤩📖🤩📖📖📖📖🤩📖📖📖📖🤩📖
📖🤩📖📖🤩📖📖🤩📖🤩📖📖🤩📖🤩📖📖🤩📖📖🤩📖🤩🤩🤩📖📖🤩🤩🤩📖📖🤩📖
📖🤩📖🤩📖🤩📖🤩📖🤩📖📖🤩📖🤩📖🤩📖🤩📖🤩📖🤩📖📖📖📖🤩📖📖📖📖📖📖
📖📖🤩📖📖📖🤩📖📖📖🤩🤩📖📖📖🤩📖📖📖🤩📖📖🤩🤩🤩🤩📖🤩🤩🤩🤩📖🤩📖
📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖
It'd be nice to update the writing stories section, but we can tackle this separately.
- Use double quotes (`"`) for the values of properties/attributes and event details. | ||
- Only use single quotes (`'`) as apostrophes. | ||
- No links or URLs allowed in descriptions. If a link is necessary, a [custom JSDoc tag](https://stenciljs.com/docs/docs-json#custom-jsdocs-tags) should be added and parsed in the SDK site. | ||
- Refrain from using "e.g." or "i.e." references. Leverage "such as" (or similar) where examples are referenced. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel personally attacked. 😲
Related Issue: #3818
Summary