Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(contributing, conventions): proofread and add additional info #5228

Merged
merged 7 commits into from
Sep 2, 2022

Conversation

benelan
Copy link
Member

@benelan benelan commented Aug 26, 2022

Related Issue: #3818

Summary

  • Added additional information to the contributing and documentation convention.
  • Fixed outdated info

@benelan benelan requested a review from a team as a code owner August 26, 2022 19:24
@benelan benelan self-assigned this Aug 26, 2022
@github-actions github-actions bot added the docs Issues relating to documentation updates only. label Aug 26, 2022
Copy link
Member

@geospatialem geospatialem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice updates - great inclusion of the style guide notes! 💯 A few small considerations.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
conventions/Documentation.md Outdated Show resolved Hide resolved
conventions/Documentation.md Outdated Show resolved Hide resolved
conventions/Documentation.md Outdated Show resolved Hide resolved
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖
📖🤩📖📖📖📖📖🤩📖📖🤩🤩📖📖🤩📖📖📖📖📖🤩📖🤩🤩🤩🤩📖🤩🤩🤩🤩📖🤩📖
📖🤩📖📖📖📖📖🤩📖🤩📖📖🤩📖🤩📖📖📖📖📖🤩📖🤩📖📖📖📖🤩📖📖📖📖🤩📖
📖🤩📖📖🤩📖📖🤩📖🤩📖📖🤩📖🤩📖📖🤩📖📖🤩📖🤩🤩🤩📖📖🤩🤩🤩📖📖🤩📖
📖🤩📖🤩📖🤩📖🤩📖🤩📖📖🤩📖🤩📖🤩📖🤩📖🤩📖🤩📖📖📖📖🤩📖📖📖📖📖📖
📖📖🤩📖📖📖🤩📖📖📖🤩🤩📖📖📖🤩📖📖📖🤩📖📖🤩🤩🤩🤩📖🤩🤩🤩🤩📖🤩📖
📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖📖

It'd be nice to update the writing stories section, but we can tackle this separately.

CONTRIBUTING.md Outdated Show resolved Hide resolved
- Use double quotes (`"`) for the values of properties/attributes and event details.
- Only use single quotes (`'`) as apostrophes.
- No links or URLs allowed in descriptions. If a link is necessary, a [custom JSDoc tag](https://stenciljs.com/docs/docs-json#custom-jsdocs-tags) should be added and parsed in the SDK site.
- Refrain from using "e.g." or "i.e." references. Leverage "such as" (or similar) where examples are referenced.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel personally attacked. 😲

conventions/Documentation.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
@benelan benelan merged commit 2898851 into master Sep 2, 2022
@benelan benelan deleted the benelan/more-contributing-info branch September 2, 2022 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues relating to documentation updates only.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants