-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(input-time): calcite-input-time component #5639
Closed
+2,075
−7
Closed
Changes from 47 commits
Commits
Show all changes
71 commits
Select commit
Hold shift + click to select a range
6655f20
feat(input-time): calcite-input-time component
eriklharper 4605d3f
implementing the interface requirements for input-time
eriklharper 2ebcae9
getting form submit behavior to work and removing unneeded resources
eriklharper a27557f
fixing form submit by adding prop decorator to name
eriklharper 70b845b
starting to flex out css
eriklharper ab46531
moar style updates, looking crazy close to a calcite-input
eriklharper d174eaf
focus rings and spacing
eriklharper 8cc29a6
removing all references to picker where appropriate and updating readme
eriklharper a733397
readonly prop and cleanup
eriklharper 3f79747
fixing reflects and readonly tests
eriklharper fe74b2f
change focus and blur to internal events and adding stubs for change …
eriklharper 4d90238
Merge branch 'eriklharper/2709-input-time' of github.com:Esri/calcite…
eriklharper 5b09e6b
updating french lang test to use danish instead so we can assert the …
eriklharper d0eeb50
moar test fixes
eriklharper 83c3b07
24-hour test with default value
eriklharper 5f3bd02
refactored setValue to include context, but might simplify it further…
eriklharper fb96021
calling setValue instead of setting value directly in setValuePart, a…
eriklharper ed151ec
Merge branch 'master' of github.com:Esri/calcite-components into erik…
eriklharper f581c2d
Removing formatted value check with current value
eriklharper d7b2e34
removing popup tests
eriklharper 6f0b9fa
created helper utils to extract localized hour, minute and second suf…
eriklharper a2c490c
Merge branch 'master' of github.com:Esri/calcite-components into erik…
eriklharper 17c53ff
Merge branch 'master' of github.com:Esri/calcite-components into erik…
eriklharper e4dfbf6
Merge branch 'eriklharper/2709-input-time' of github.com:Esri/calcite…
eriklharper 8c3de9b
Merge branch 'master' of github.com:Esri/calcite-components into erik…
eriklharper a35f3fe
fixing tests
eriklharper cf5a2c4
Merge branch 'master' of github.com:Esri/calcite-components into erik…
eriklharper e72b740
Merge branch 'master' of github.com:Esri/calcite-components into erik…
eriklharper 363f5df
Merge branch 'master' of github.com:Esri/calcite-components into erik…
eriklharper 010aa1f
Merge branch 'master' of github.com:Esri/calcite-components into erik…
eriklharper 1695a0b
Merge branch 'master' of github.com:Esri/calcite-components into erik…
eriklharper 4f40b5d
Merge branch 'master' of github.com:Esri/calcite-components into erik…
eriklharper 9135667
removing time-picker from input-time demo page
eriklharper 3afd715
first start to reconciling the input and change events. Need to get …
eriklharper d840e27
fixing input and change eventing
eriklharper 4995c82
fire change event on blur only when the value changed
eriklharper 3038b29
Removing unnecessary test and using null instead of undefined for ini…
eriklharper a29e090
fire input event when value is cleared and change event when committed
eriklharper ae4cbf5
match native: allow clearing any field without affecting the other fi…
eriklharper 85d0834
updating to [email protected] with new text highlight color, and …
eriklharper fd02493
removing unneeded todo for now and renaming direct value change test
eriklharper cebc33f
LoadableComponent interface
eriklharper 68d638b
Merge branch 'master' of github.com:Esri/calcite-components into erik…
eriklharper b685fd0
matching figma designs, updating story and demo pages, increases size…
eriklharper 6159644
readonly visual state
eriklharper 102fa15
internal clicks outside time inputs focus the hour input
eriklharper c32aa1b
fixing previousValue bug, don't know why it can't be set to private
eriklharper cd2d261
Merge branch 'master' of github.com:Esri/calcite-components into erik…
eriklharper 660ef17
Merge branch 'master' of github.com:Esri/calcite-components into erik…
eriklharper f06f8f3
Merge branch 'master' of github.com:Esri/calcite-components into erik…
eriklharper 7e6fa0d
moving input-time to new monorepo location and updating input-time de…
eriklharper e0ceff4
adding missing form prop
eriklharper a431d44
Merge branch 'main' of github.com:Esri/calcite-design-system into eri…
eriklharper 91842fb
Merge branch 'main' of github.com:Esri/calcite-design-system into eri…
eriklharper 4a5ac10
switching to new time util for fetching suffixes
eriklharper 8131538
adding temporary highlight color while we wait for the design tokens …
eriklharper 57a1504
updating demo page to include milliseconds
eriklharper b4f64da
removing redundant interface reference in time-picker
eriklharper 87eed03
implementing LocalizedComponent interface
eriklharper cdb3b66
support numbering-system
eriklharper 4178d39
implement T9nComponent interface
eriklharper 550814a
adding missed t9n stuff
eriklharper ec8eeb1
adding translation message bundles, modified to remove up and down me…
eriklharper 9554cf4
refactoring setValue and setValuePart to match time-picker sans fract…
eriklharper f2d8bdb
removing previousEmittedValue and emitChangeIfUserModified since we'r…
eriklharper 9d66f9d
setting value to empty string
eriklharper cc4e559
fractional second support and cleaning up unused css classnames
eriklharper c9bbff9
Merge branch 'main' of github.com:Esri/calcite-design-system into eri…
eriklharper 301cda4
Merge branch 'main' of github.com:Esri/calcite-design-system into eri…
eriklharper 7423586
fixing common tests
eriklharper 2a1ac41
Merge branch 'main' of github.com:Esri/calcite-design-system into eri…
eriklharper File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make sure this is updated on
master
in a separate PR before this one is merged