Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alert): placement of link consistent with notice #5852

Merged
merged 3 commits into from
Dec 1, 2022

Conversation

Elijbet
Copy link
Contributor

@Elijbet Elijbet commented Nov 30, 2022

Related Issue: #5254

Summary

The notice and alert slots have the same placement and styling for the slotted link content.

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Nov 30, 2022
@Elijbet Elijbet marked this pull request as ready for review November 30, 2022 19:35
@Elijbet Elijbet requested a review from a team as a code owner November 30, 2022 19:35
@Elijbet Elijbet added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Nov 30, 2022
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 approved!

@Elijbet Elijbet merged commit 56e35ab into master Dec 1, 2022
@Elijbet Elijbet deleted the elijbet/5254-alert-link-slot-placement-match-notice branch December 1, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants