fix(tab-title): tabs center when set to layout='center'
#7026
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,40 @@ | |
| :host([layout="center"]) { | ||
| @apply my-0 mx-5 text-center; | ||
| flex-basis: theme("spacing.48"); | ||
| .content { | ||
| @apply m-auto; | ||
| } | ||
| } | ||
|
|
||
| // center the text visually and not affected by the x button so as to avoid moving when on or off | ||
| :host([layout="center"][closable]) { | ||
| .content { | ||
| padding-inline-start: 32px; //28px button width + 0.25rem padding | ||
| } | ||
|
There was a problem hiding this comment. Can I get guidance on how to implement tokens here? Or is it something we could do as a follow-up like you said earlier @driskull? There was a problem hiding this comment. @Elijbet this is good for the release. Can you open an issue to address this by using our design tokens/tailwind for this padding? Ideally both the button width and padding should be tied to variables. |
||
| } | ||
|
|
||
| :host([layout="center"][bordered][closable][scale="s"]) { | ||
| .content { | ||
| padding-inline-start: 36px; //28px button width + 0.5rem padding | ||
| } | ||
| } | ||
|
|
||
| :host([layout="center"][bordered][closable][scale="m"]) { | ||
| .content { | ||
| padding-inline-start: 40px; //28px button width + 0.75rem padding | ||
| } | ||
| } | ||
|
|
||
| :host([layout="center"][closable][scale="l"]) { | ||
| .content { | ||
| padding-inline-start: 40px; //36px button width + .25 padding | ||
| } | ||
| } | ||
|
|
||
| :host([layout="center"][closable][bordered][scale="l"]) { | ||
| .content { | ||
| padding-inline-start: 52px; //36px button width + 1rem padding | ||
| } | ||
| } | ||
|
|
||
| :host([position="bottom"]) .container { | ||
|
|
@@ -192,9 +225,15 @@ | |
|
|
||
| :host([closable]) .container, | ||
| :host([bordered]) .container { | ||
| border-inline-start: 1px solid transparent; | ||
| border-inline-end: 1px solid transparent; | ||
| .close-button { | ||
| margin-inline: 0; | ||
| } | ||
| } | ||
|
|
||
| :host([closable]) .content { | ||
| @apply h-full box-border border-b-color-transparent; | ||
| } | ||
|
|
||
| :host([closable][position="bottom"]) .container, | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
given that there's no difference between
margin: autoand@apply m-autoI'd recommend usingmargin: autoit's more readableThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're using tailwind for now, it makes sense to stick to tailwind classes if they are available, for consistency. This is what we've been doing so far. Also, overlapping uses of tailwind and regular css props might create oversight doubling use of both by accident.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, lets keep tailwind for now for consistency. Hopefully we can remove tailwind in the future.