Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: drop calcite-base and calcite-colors in favor of tokens and inlined vars/utils #8382

Draft
wants to merge 7 commits into
base: dev
Choose a base branch
from
Draft

refactor: drop calcite-base and calcite-colors in favor of tokens and inlined vars/utils #8382

wants to merge 7 commits into from

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Dec 8, 2023 •
edited
Loading

Related Issue: N/A

Summary

calcite-base and calcite-colors are legacy dependencies that are used for a small set of variables. This PR removes them as dependencies by switching over to CSS design tokens or inlining some values within our style files. 📦✂️

Notes

  • modal's breakpoints were replaced with the closest matching breakpoint tokens, which are close within ~10px

Pending

  • update styles readme to reference tokens
  • confirm whether we want to use --calcite-color-brand-underline (or alternate token) instead of brand-color + 0.5 opacity in stepper.

Next steps

  • create follow-up issue to
    • replace the easing function with token (if applicable)
    • update floating-ui to use either --calcite-shadow-sm, --calcite-shadow-md or new one if needed.
    • remove inlined baseline var in modal

@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Dec 8, 2023
@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Dec 8, 2023
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Dec 8, 2023
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Dec 12, 2023
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Dec 19, 2023
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Dec 19, 2023
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Dec 19, 2023
@jcfranco
Copy link
Member Author

@alisonailea Do you think you could help me update to the styles readme? 🙇‍♂️

@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Dec 28, 2023
@jcfranco
Copy link
Member Author

#8594 will replace some of the inlined vars/utils in this PR, so this should be revisited once ☝️ lands.

@github-actions github-actions bot removed the Stale Issues or pull requests that have not had recent activity. label Mar 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Mar 27, 2024
@benelan benelan changed the base branch from main to dev June 10, 2024 09:16
@github-actions github-actions bot removed the Stale Issues or pull requests that have not had recent activity. label Jun 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benelan benelan Awaiting requested review from benelan benelan will be requested when the pull request is marked ready for review benelan is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@jcfranco jcfranco

Labels
pr ready for visual snapshots Adding this label will run visual snapshot testing. refactor Issues tied to code that needs to be significantly reworked. Stale Issues or pull requests that have not had recent activity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jcfranco