Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: restore skipped tests #8987

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,7 @@ describe("calcite-action-bar", () => {
expect(await page.findAll(slottedActionsSelector)).toHaveLength(7);
});

it.skip("should slot 'menu-actions' on resize of component", async () => {
it("should slot 'menu-actions' on resize of component", async () => {
const page = await newE2EPage({
html: html`<div style="width:500px; height:500px;">
<calcite-action-bar style="height: 290px">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,7 @@ describe("calcite-action-menu", () => {
expect(await trigger.getProperty("active")).toBe(false);
});

it.skip("should handle TAB navigation", async () => {
it("should handle TAB navigation", async () => {
const page = await newE2EPage({
html: html`<calcite-action-menu>
<calcite-action id="first" text="Add" icon="plus" text-enabled></calcite-action>
Expand Down
4 changes: 2 additions & 2 deletions packages/calcite-components/src/components/alert/alert.e2e.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@ describe("calcite-alert", () => {
hidden("<calcite-alert open></calcite-alert>");
});

describe.skip("accessible", () => {
describe("accessible", () => {
accessible(html` <calcite-alert open label="test"> ${alertContent} </calcite-alert> `);
});

describe.skip("accessible with auto-close", () => {
describe("accessible with auto-close", () => {
accessible(html`
<calcite-alert open auto-close auto-close-duration="slow" label="test"> ${alertContent} </calcite-alert>
`);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -451,15 +451,15 @@ describe("calcite-color-picker-hex-input", () => {
input = await page.find("calcite-color-picker-hex-input");
});

it.skip("commits hexa chars on Tab and Enter", async () => {
it("commits hexa chars on Tab and Enter", async () => {
await assertTabAndEnterBehavior("b00", "#bb0000ff", true);
await assertTabAndEnterBehavior("abcd", "#aabbccdd", true);
await assertTabAndEnterBehavior("c0ffee", "#c0ffeeff", true);
await assertTabAndEnterBehavior("b0b0b0b0", "#b0b0b0b0", true);
await assertTabAndEnterBehavior("", startingHexa, true);
});

it.skip("prevents committing invalid hexa values", async () => {
it("prevents committing invalid hexa values", async () => {
await assertTabAndEnterBehavior("aabbccd", startingHexa, true);
await assertTabAndEnterBehavior("aabbcc", "#aabbccff", true);
await assertTabAndEnterBehavior("ff00f", "#aabbccff", true);
Expand Down Expand Up @@ -502,15 +502,15 @@ describe("calcite-color-picker-hex-input", () => {
await page.waitForChanges();
});

it.skip("commits hexa chars on Tab and Enter", async () => {
it("commits hexa chars on Tab and Enter", async () => {
await assertTabAndEnterBehavior("b00", "#bb0000ff", true);
await assertTabAndEnterBehavior("baba", "#bbaabbaa", true);
await assertTabAndEnterBehavior("c0ffee", "#c0ffeeff", true);
await assertTabAndEnterBehavior("c0c0c0c0", "#c0c0c0c0", true);
await assertTabAndEnterBehavior("", null, true);
});

it.skip("prevents committing invalid hexa values", async () => {
it("prevents committing invalid hexa values", async () => {
await assertTabAndEnterBehavior("aabbccd", startingHexa, true);
await assertTabAndEnterBehavior("aabbcc", "#aabbccff", true);
await assertTabAndEnterBehavior("ff00f", "#aabbccff", true);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ describe("calcite-date-picker", () => {
expect(changedEvent).toHaveReceivedEventTimes(0);
});

it.skip("correctly changes date on next/prev", async () => {
it("correctly changes date on next/prev", async () => {
const page = await newE2EPage();
await page.setContent("<calcite-date-picker value='2000-11-27'></calcite-date-picker>");
const getMonth = () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ describe("calcite-dropdown", () => {
hidden("calcite-dropdown");
});

describe.skip("disabled", () => {
describe("disabled", () => {
disabled(simpleDropdownHTML, {
focusTarget: {
tab: "calcite-button",
Expand Down Expand Up @@ -1174,7 +1174,7 @@ describe("calcite-dropdown", () => {
await expect(finalSelectedItem).toBe("item-3");
});

it.skip("dropdown should not overflow when wrapped inside a tab #3007", async () => {
it("dropdown should not overflow when wrapped inside a tab #3007", async () => {
const page = await newE2EPage({
html: html`<calcite-tabs>
<calcite-tab-nav slot="title-group">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ describe("calcite-icon", () => {
expect(path.getAttribute("d")).toBe(iconPathData);
});

it.skip("loads icon when it's close to viewport", async () => {
it("loads icon when it's close to viewport", async () => {
const page = await newE2EPage();
await page.setContent(`<calcite-icon icon="a-z" style="margin-top: 1000px"></calcite-icon>`);
await page.waitForChanges();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ describe("calcite-input-date-picker", () => {
openClose(`<calcite-input-date-picker id="pickerOpenClose" value="2021-12-08"></calcite-input-date-picker>`);
});

it.skip("supports t9n", () => t9n("calcite-input-date-picker"));
it("supports t9n", () => t9n("calcite-input-date-picker"));

async function navigateMonth(page: E2EPage, direction: "previous" | "next"): Promise<void> {
const linkIndex = direction === "previous" ? 0 : 1;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ describe("calcite-input-number", () => {
});
});

describe.skip("increment/decrement functionality", () => {
describe("increment/decrement functionality", () => {
let page: E2EPage;
beforeEach(async () => {
page = await newE2EPage();
Expand Down Expand Up @@ -574,7 +574,7 @@ describe("calcite-input-number", () => {
buttonUpLocation = [x, y];
});

it.skip("should emit an event regularly on mousedown", async () => {
it("should emit an event regularly on mousedown", async () => {
expect(calciteInputNumberInput).toHaveReceivedEventTimes(0);
await page.mouse.move(buttonUpLocation.x, buttonUpLocation.y);
await page.mouse.down();
Expand All @@ -585,7 +585,7 @@ describe("calcite-input-number", () => {
expect(await input.getProperty("value")).toBe(`${totalNudgesUp}`);
});

it.skip("should stop emitting an event on mouseleave", async () => {
it("should stop emitting an event on mouseleave", async () => {
expect(calciteInputNumberInput).toHaveReceivedEventTimes(0);
await page.mouse.move(buttonUpLocation.x, buttonUpLocation.y);
await page.mouse.down();
Expand All @@ -612,7 +612,7 @@ describe("calcite-input-number", () => {
buttonDownLocation = [x, y];
});

it.skip("should emit an event regularly on mousedown", async () => {
it("should emit an event regularly on mousedown", async () => {
expect(calciteInputNumberInput).toHaveReceivedEventTimes(0);
await page.mouse.move(buttonDownLocation.x, buttonDownLocation.y);
await page.mouse.down();
Expand All @@ -623,7 +623,7 @@ describe("calcite-input-number", () => {
expect(await input.getProperty("value")).toBe(`${totalNudgesUp}`);
});

it.skip("should stop emitting an event on mouseleave", async () => {
it("should stop emitting an event on mouseleave", async () => {
expect(calciteInputNumberInput).toHaveReceivedEventTimes(0);
await page.mouse.move(buttonDownLocation.x, buttonDownLocation.y);
await page.mouse.down();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ describe("calcite-input-text", () => {
expect(changeEventSpy).not.toHaveReceivedEvent();
});

it.skip("emits events when value is modified", async () => {
it("emits events when value is modified", async () => {
const page = await newE2EPage();
await page.setContent(html`<calcite-input-text></calcite-input-text>`);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ describe("calcite-input-time-picker", () => {
`);
});

it.skip("supports t9n", () => t9n("calcite-input-time-picker"));
it("supports t9n", () => t9n("calcite-input-time-picker"));

describe("defaults", () => {
defaults("calcite-input-time-picker", [
Expand Down Expand Up @@ -648,7 +648,7 @@ describe("calcite-input-time-picker", () => {
expect(await inputTimePicker.getProperty("value")).toBe("14:05:00");
});

it.skip("correctly relocalizes the display value when the lang and numbering systems change", async () => {
it("correctly relocalizes the display value when the lang and numbering systems change", async () => {
const page = await newE2EPage();
await page.setContent(`<calcite-input-time-picker step="1" value="14:30:25"></calcite-input-time-picker>`);
const inputTimePicker = await page.find("calcite-input-time-picker");
Expand Down Expand Up @@ -712,7 +712,7 @@ describe("calcite-input-time-picker", () => {
expect(await getInputValue(page)).toBe("٠١٢٣٤٥٦٧٨٩");
});

it.skip("committing typed value works as expected in arab numbering system", async () => {
it("committing typed value works as expected in arab numbering system", async () => {
const page = await newE2EPage();
await page.setContent(
`<calcite-input-time-picker step="1" lang="ar" numbering-system="arab"></calcite-input-time-picker>`,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ describe("calcite-list", () => {
hidden("calcite-list");
});

describe.skip("translation support", () => {
describe("translation support", () => {
t9n("calcite-list");
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ describe("calcite-pick-list-group", () => {
});

// eslint-disable-next-line jest/no-disabled-tests
describe.skip("accessible", () => {
describe("accessible", () => {
accessible("<calcite-pick-list-group></calcite-pick-list-group>");
accessible(`<calcite-pick-list-group title="awesome title"></calcite-pick-list-group>`);
accessible(html`
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ describe("calcite-pick-list-item", () => {
});

// eslint-disable-next-line jest/no-disabled-tests
describe.skip("accessible", () => {
describe("accessible", () => {
accessible(html`
<calcite-pick-list>
<calcite-pick-list-item label="test" description="a number" value="one"></calcite-pick-list-item>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ describe("calcite-pick-list", () => {
});

// eslint-disable-next-line jest/no-disabled-tests
describe.skip("accessible", () => {
describe("accessible", () => {
accessible(html`
<calcite-pick-list>
<calcite-pick-list-item label="Sample" value="one"></calcite-pick-list-item>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ export function keyboardNavigation(listType: ListType): void {
});
});

it.skip("should honor filterText", async () => {
it("should honor filterText", async () => {
const page = await newE2EPage({
html: `
<calcite-${listType}-list filter-enabled filter-text="one">
Expand All @@ -193,7 +193,7 @@ export function keyboardNavigation(listType: ListType): void {
expect(await list.getProperty("filterText")).toBe("one");
});

it.skip("navigating items after filtering", async () => {
it("navigating items after filtering", async () => {
const page = await newE2EPage({
html: `
<calcite-${listType}-list filter-enabled>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -682,7 +682,7 @@ describe("calcite-popover", () => {
});
});

describe.skip("should focus close button", () => {
describe("should focus close button", () => {
focusable(createPopoverHTML(contentHTML, "closable"), {
shadowFocusTargetSelector: `.${CSS.closeButton}`,
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,7 @@ describe("calcite-radio-button", () => {
expect(blurEvent).toHaveReceivedEventTimes(1);
});

it.skip("appropriately triggers the custom internal focus and blur events with keyboard", async () => {
it("appropriately triggers the custom internal focus and blur events with keyboard", async () => {
const page = await newE2EPage();
await page.setContent(
`<calcite-radio-button name="example"></calcite-radio-button><calcite-radio-button name="example"></calcite-radio-button>`,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ describe("calcite-stepper", () => {
});

// eslint-disable-next-line jest/no-disabled-tests
describe.skip("honors hidden attribute", () => {
describe("honors hidden attribute", () => {
hidden("calcite-stepper");
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ describe("calcite-tab-title", () => {
});
});

it.skip("emits active event on user interaction only", async () => {
it("emits active event on user interaction only", async () => {
const page = await newE2EPage();
await page.setContent(`<calcite-tab-title>Title</calcite-tab-title>`);
const activeEventSpy = await page.spyOnEvent("calciteTabsActivate");
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// TODO: Uncomment this test when there's a resolution to this bug. https://github.com/ionic-team/stencil/issues/1669
// import { TipManager } from "./calcite-tip-manager";

describe.skip("TipManager", () => {
describe("TipManager", () => {
it("should increment/decrement the selectedIndex when the public next/prev methods are called", () => {
// const tipManager = new TipManager();
// tipManager.total = 2; //needed to
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -864,7 +864,7 @@ describe("calcite-tooltip", () => {
});
});

it.skip("should open hovered tooltip while pointer is moving", async () => {
it("should open hovered tooltip while pointer is moving", async () => {
const page = await newE2EPage();
await page.setContent(html`
<calcite-tooltip reference-element="ref">Content</calcite-tooltip>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ describe("calcite-value-list-item", () => {
});

// eslint-disable-next-line jest/no-disabled-tests
describe.skip("accessible", () => {
describe("accessible", () => {
accessible(html`
<calcite-value-list>
<calcite-value-list-item label="test" description="a number" value="one"></calcite-value-list-item>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ describe("calcite-value-list", () => {
});

// eslint-disable-next-line jest/no-disabled-tests
describe.skip("accessible", () => {
describe("accessible", () => {
accessible(html`
<calcite-value-list>
<calcite-value-list-item label="Sample" value="one"></calcite-value-list-item>
Expand Down
Loading