Hidden dropdowns (#1051)

* #1050 - fix dropdown lists with hidden elements * 📦 v1.2.3
Esri · Jan 23, 2019 · 39790af · 39790af
1 parent 4527df1
commit 39790af
Show file tree

Hide file tree

Showing 18 changed files with 32 additions and 22 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,8 @@
+## [1.2.3]
+
+### Fixes
+- fix dropdown arrow keys with hidden elements (#1050)
+
 ## [1.2.2]
 
 ### Fixes
@@ -1413,6 +1418,7 @@ Begin foundational sass for the framework.
 - CSS Reset
 - Grunt Workflows
 
+[1.2.3]: https://github.com/esri/calcite-web/compare/v1.2.2...v1.2.3
 [1.2.2]: https://github.com/esri/calcite-web/compare/v1.2.1...v1.2.2
 [1.2.1]: https://github.com/esri/calcite-web/compare/v1.2.0...v1.2.1
 [1.2.0]: https://github.com/esri/calcite-web/compare/v1.1.0...v1.2.0

diff --git a/dist/css/calcite-web-dark.css b/dist/css/calcite-web-dark.css
@@ -1,6 +1,6 @@
 /*!
  * Calcite Web - Calcite Design Components in CSS, JS and HTML
- * @version v1.2.1
+ * @version v1.2.3
  * @license Apache-2.0
  * @copyright 2018 Esri
  * @link https://github.com/Esri/calcite-web

diff --git a/dist/css/calcite-web-dark.min.css b/dist/css/calcite-web-dark.min.css
diff --git a/dist/css/calcite-web-e-commerce.css b/dist/css/calcite-web-e-commerce.css
@@ -1,6 +1,6 @@
 /*!
  * Calcite Web - Calcite Design Components in CSS, JS and HTML
- * @version v1.2.1
+ * @version v1.2.3
  * @license Apache-2.0
  * @copyright 2018 Esri
  * @link https://github.com/Esri/calcite-web

diff --git a/dist/css/calcite-web-e-commerce.min.css b/dist/css/calcite-web-e-commerce.min.css
diff --git a/dist/css/calcite-web-marketing.css b/dist/css/calcite-web-marketing.css
@@ -1,6 +1,6 @@
 /*!
  * Calcite Web - Calcite Design Components in CSS, JS and HTML
- * @version v1.2.1
+ * @version v1.2.3
  * @license Apache-2.0
  * @copyright 2018 Esri
  * @link https://github.com/Esri/calcite-web

diff --git a/dist/css/calcite-web-marketing.min.css b/dist/css/calcite-web-marketing.min.css
diff --git a/dist/css/calcite-web-no-fonts.css b/dist/css/calcite-web-no-fonts.css
@@ -1,6 +1,6 @@
 /*!
  * Calcite Web - Calcite Design Components in CSS, JS and HTML
- * @version v1.2.1
+ * @version v1.2.3
  * @license Apache-2.0
  * @copyright 2018 Esri
  * @link https://github.com/Esri/calcite-web

diff --git a/dist/css/calcite-web-no-fonts.min.css b/dist/css/calcite-web-no-fonts.min.css
diff --git a/dist/css/calcite-web.css b/dist/css/calcite-web.css
@@ -1,6 +1,6 @@
 /*!
  * Calcite Web - Calcite Design Components in CSS, JS and HTML
- * @version v1.2.1
+ * @version v1.2.3
  * @license Apache-2.0
  * @copyright 2018 Esri
  * @link https://github.com/Esri/calcite-web

diff --git a/dist/css/calcite-web.min.css b/dist/css/calcite-web.min.css
diff --git a/dist/js/calcite-web-marketing.js b/dist/js/calcite-web-marketing.js
@@ -1,6 +1,6 @@
 /*!
  * Calcite Web - Calcite Design Components in CSS, JS and HTML
- * @version v1.2.1
+ * @version v1.2.3
  * @license Apache-2.0
  * @copyright 2018 Esri
  * @link https://github.com/Esri/calcite-web

diff --git a/dist/js/calcite-web-marketing.min.js b/dist/js/calcite-web-marketing.min.js
diff --git a/dist/js/calcite-web.js b/dist/js/calcite-web.js
@@ -1,6 +1,6 @@
 /*!
  * Calcite Web - Calcite Design Components in CSS, JS and HTML
- * @version v1.2.1
+ * @version v1.2.3
  * @license Apache-2.0
  * @copyright 2018 Esri
  * @link https://github.com/Esri/calcite-web
@@ -580,15 +580,17 @@ function dropownFocusOn (options) {
 function arrowDown () {
   var dropdown = dropdownIsOpen();
   if (dropdown) {
-    var links = findElements('.dropdown-link', dropdown);
+    var links = findElements('.dropdown-link', dropdown)
+      .filter(function (link) { return link.offsetParent !== null; });
     bus.emit('dropdown:focus', {links: links, forward: true});
   }
 }
 
 function arrowUp () {
   var dropdown = dropdownIsOpen();
   if (dropdown) {
-    var links = findElements('.dropdown-link', dropdown);
+    var links = findElements('.dropdown-link', dropdown)
+      .filter(function (link) { return link.offsetParent !== null; });
     bus.emit('dropdown:focus', {links: links, forward: false});
   }
 }
@@ -1404,7 +1406,7 @@ function extend (plugin) {
 // │ Public API │
 // └────────────┘
 // define all public api methods
-var version = '1.2.0';
+var version = '1.2.3';
 var click$1 = click;
 var addEvent = add$1;
 var removeEvent = remove$1;

diff --git a/dist/js/calcite-web.min.js b/dist/js/calcite-web.min.js
diff --git a/es6.js b/es6.js
@@ -119,7 +119,7 @@ function extend (plugin) {
 // │ Public API │
 // └────────────┘
 // define all public api methods
-var version = '1.2.0';
+var version = '1.2.3';
 var click = event.click;
 var addEvent = event.add;
 var removeEvent = event.remove;

diff --git a/lib/js/patterns/dropdown.js b/lib/js/patterns/dropdown.js
@@ -105,15 +105,17 @@ function dropownFocusOn (options) {
 function arrowDown () {
   var dropdown = dropdownIsOpen();
   if (dropdown) {
-    var links = dom.findElements('.dropdown-link', dropdown);
+    var links = dom.findElements('.dropdown-link', dropdown)
+      .filter(link => link.offsetParent !== null);
     bus.emit('dropdown:focus', {links: links, forward: true});
   }
 }
 
 function arrowUp () {
   var dropdown = dropdownIsOpen();
   if (dropdown) {
-    var links = dom.findElements('.dropdown-link', dropdown);
+    var links = dom.findElements('.dropdown-link', dropdown)
+      .filter(link => link.offsetParent !== null);
     bus.emit('dropdown:focus', {links: links, forward: false});
   }
 }

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "calcite-web",
-  "version": "1.2.2",
+  "version": "1.2.3",
   "description": "SASS & CSS Framework for Esri websites",
   "private": true,
   "homepage": "https://github.com/esri/calcite-web",