Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: importing props/mounts in projects #148

Merged
merged 2 commits into from
Mar 19, 2025

Conversation

Bronya-Rand
Copy link
Contributor

@Bronya-Rand Bronya-Rand commented Mar 11, 2025

This addresses two issues reported by Holo in Aetherworks where the Shader code would apply to props and break mounts during a project import.

The main cause of the issue was that props/mounts don't really have a extended appearance and thus:

  1. If the actorFile is a prop, the shader code applies and defaults to (what I assume is your actual character) a generic character appearing alongside the prop itself.
  2. When saving a project, the ShaderParams argurment is required which can cause saving issues for props/mounts.

For 1, all that needed to be done is expand the if calls for props and add a fallback result for chars with bad shaders. For 2, I made the argument for shaders in the ActorExtendedAppearance optional for.

@Bronya-Rand Bronya-Rand changed the title fix: importing props in projects fix: importing props/mounts in projects Mar 11, 2025
@Minmoose Minmoose added this to the 0.5.1 milestone Mar 14, 2025
@Minmoose Minmoose merged commit ab2b71a into Etheirys:main Mar 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants