Add speaker edit view (fix #932) #934
Conversation
conference/cfp.py
Outdated
| ) | ||
|
|
||
| if request.method == 'POST': | ||
| speaker_form = AddSpeakerToTalkForm(request.POST) |
There was a problem hiding this comment.
I think in this case we might want to update the form name (or created an alias for this form with some other name that better suits this view)
| {% endblock %} | ||
|
|
||
| {% block morejs %} | ||
| <script src="{% static "/js/taggit_labels_customised_with_max_number_of_tags.js" %}"></script> |
There was a problem hiding this comment.
This is not needed for speakers, same for the CSS above.
There was a problem hiding this comment.
Thanks for catching this, removing!
| @@ -32,7 +35,6 @@ def test_if_cfp_pages_are_login_required(client, url): | |||
| assert redirects_to(response, "/accounts/login/") | |||
|
|
|||
|
|
|||
| @mark.django_db | |||
There was a problem hiding this comment.
👍
what we could also do is make user_client fixture explicitly depend on db fixture which should do the same in a slightly more explicit way.
There was a problem hiding this comment.
Would that mean that all django_db tests would have to accept user_client as an argument?
There was a problem hiding this comment.
other way around – user_client would take db as argument, which it needs anyway because it creates users.
umgelurgel
force-pushed
the
issue-932-add-speaker-edit-view
branch
from
c496867 to
681d708
Compare
Fixes #932