Only merge in open_run(..., data='all') if raw is not a subset of proc #236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
open_run(..., data='all')
throws an exception since #208 ifraw
is completely a subset ofproc
, because it will try to access the metadata ofraw
\proc
while merging this intoproc
. If this set is empty however, the call toDataCollection.run_metadata()
fails due to access tofiles[0]
.While this begs a larger question of whether such
DataCollection
objects such exist in the first place, @takluyver and me agreed to discuss this separately in #235. It is clearly not necessary and thus a bug inopen_run
do try this in the first place if theDataCollection
is empty anyway.