Geometry from Karabo #330
Geometry from Karabo #330
Conversation
| install_requires=[ | ||
| 'Karabo-proxy', |
There was a problem hiding this comment.
Can we make this an optional dependency, using the extras_require section below? If people are installing our tools in their own environment, I try to keep the number of dependencies minimal.
There was a problem hiding this comment.
Hmm, then I we also need to catch exception on import...
There was a problem hiding this comment.
If you want to, but I think it's also OK to just let the ImportError show in that case.
|
|
||
|
|
||
| def deserialize_geometry(serialized: str): | ||
| return pickle.loads(gzip.decompress(base64.b64decode(serialized.encode()))) |
There was a problem hiding this comment.
I just realised what this is doing.
Unpickling may not work if the version of EXtra-geom installed in Karabo is different from the version locally. Recent versions haven't changed the structure much, but that's not guaranteed for the future, and the failures if you unpickle something from a different version can be very confusing. It also means that anyone calling this is potentially vulnerable to a MITM attack: unpickling is equivalent to eval() in security terms.
So I'd rather not do this if we can avoid it. If a major use case is to retrieve a .geom file, one option is that the geometry device could expose a slot to create the file, and we call that and write the returned data directly to a file.
This adds script requesting geometry from Karabo
@takluyver @JamesWrigley