Fix PumpProbePulses.pulse_mask() for empty or partially empty trains #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philsmt
force-pushed
the
fix/pumpprobe-empty-pulses
branch
from
9675cf4 to
219c60a
Compare
|
Thanks for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bj-s reported an issue with
PumpProbePulses.pulse_mask()in a run where all trains are pumped, but every 50th train has no FEL pulses.The special implementation of
pulse_mask()implicitly assumed every train to have at least one FEL and PPL pulse in its implementation. Additionally while fixing this, I noticed it was not included in the fixes in #100 regarding handling of trains without pulses.Extended the tests to cover what previously failed.