customValidator Test Update #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Code Climate has analyzed commit 860fd25 and detected 0 issues on this pull request. View more on Code Climate. |
icemedia001
force-pushed
the
customValidatorTest
branch
from
860fd25 to
dc7ed51
Compare
AshakaE
requested changes
Nov 5, 2024
Comment on lines
44
to
64
| it('should return true for valid strings with alphanumeric characters', async () => { | ||
| const validInputs = [ | ||
| 'abc123', | ||
| 'ABC123', | ||
| 'Test123', | ||
| 'Hello World', | ||
| 'Test-123', | ||
| 'Test.123', | ||
| 'Test/123', | ||
| 'Test (123)', | ||
| '', | ||
| ] | ||
|
|
||
| for (const input of validInputs) { | ||
| const result = await validStringParams.validate( | ||
| input, | ||
| mockValidationArguments, | ||
| ) | ||
| expect(result).toBe(true) | ||
| } | ||
| }) |
There was a problem hiding this comment.
We need to update the regex, valid string params should contain at most the hyphen - special character otherwise it's invalid .. examples 54dd0bb4-f570-4771-8ba4-59bade1debc8 and test123
Comment on lines
203
to
231
| describe('validDateParams', () => { | ||
| it('should return true for valid date strings in YYYY-MM-DD format', async () => { | ||
| const validDates = ['2024-01-01', '1999-12-31', '2020-02-29'] | ||
| for (const date of validDates) { | ||
| const result = await validDateParams.validate( | ||
| date, | ||
| mockValidationArguments, | ||
| ) | ||
| expect(result).toBe(true) | ||
| } | ||
| }) | ||
|
|
||
| it('should return true for null or undefined dates', async () => { | ||
| expect( | ||
| await validDateParams.validate(null as any, mockValidationArguments), | ||
| ).toBe(true) | ||
| expect( | ||
| await validDateParams.validate( | ||
| undefined as any, | ||
| mockValidationArguments, | ||
| ), | ||
| ).toBe(true) | ||
| }) | ||
|
|
||
| it('should return the default error message for invalid date strings', () => { | ||
| const message = validDateParams.defaultMessage(mockValidationArguments) | ||
| expect(message).toBe('Invalid date string parameters') | ||
| }) | ||
| }) |
There was a problem hiding this comment.
we should also update this regex, validDateParams should take values like '2024-01-01' or '2024/01/01'
AshakaE
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
customValidator Test Update
Update unit tests for customValidator to validate alphanumeric strings with specific allowed characters and ensure proper error messaging for invalid inputs.
pnpm test customValidator.spec.ts
closes EveripediaNetwork/issues#3482