Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/hiiq holders table #285

Merged
merged 22 commits into from
Nov 26, 2024
Merged

Feat/hiiq holders table #285

merged 22 commits into from
Nov 26, 2024

Conversation

invisiblemask
Copy link
Contributor

@invisiblemask invisiblemask commented Nov 19, 2024

Add HIIQ Holders Table

This PR introduces the addition of HIIQ holders table to the dashboard

  • Table consists of the total count for HIIQ holders which is updated daily
  • Lists of all the holders with their addresses, balance, and date staked which is also updated daily

Linked issues

closes EveripediaNetwork/issues#3369
closes EveripediaNetwork/issues#3423

Copy link

stackblitz bot commented Nov 19, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
iq-dashboard ✅ Ready (Inspect) Visit Preview Nov 25, 2024 1:23pm

@SidharthK2
Copy link
Contributor

@Simplypheyie96 We don't have date staked data as of now, what do you think we should replace it with? or omit it entirely.

@Simplypheyie96
Copy link

Simplypheyie96 commented Nov 21, 2024

@Simplypheyie96 We don't have date staked data as of now, what do you think we should replace it with? or omit it entirely.

Oh.
It was in the wireframe given. Do we have data for date of the last stake?

If we don't. Let's remove it

Copy link

@Simplypheyie96 Simplypheyie96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not quite right
image

It should be more like this.
with divider line and reduced space.

image

the padding around the tag should be reduced too
image

Refresh button doesn't work


Since other metrics will be added later, this would be all.

@Simplypheyie96
Copy link

image
@invisiblemask Great. let's update the divider's color in both dark and light mode and also refresh button is not working still

@Dewalz Dewalz self-requested a review November 21, 2024 13:01
Copy link

@Dewalz Dewalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the subhead is not visible in dark mode, also the pink color still same as light mode
Screenshot 2024-11-21 at 1 44 00 PM

@Dewalz
Copy link

Dewalz commented Nov 21, 2024

when the HiIq holder tab is selected, the hover effect on the stake in side bar disappears
Screenshot 2024-11-21 at 1 46 25 PM

@Dewalz
Copy link

Dewalz commented Nov 21, 2024

the gray fill is missing in light mode
Screenshot 2024-11-21 at 1 49 17 PM

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 23301 lines exceeds the maximum allowed for the inline comments feature.

@invisiblemask invisiblemask force-pushed the feat/hiiq-holders-table branch from e6618e2 to e30f2f9 Compare November 22, 2024 07:49
Copy link

@Simplypheyie96 Simplypheyie96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Adjust font color in light mode:
    image
  • We probably shouldn't have this page if there is no result to display
    image
  • Let's adjust the table on mobile breakpoint
image
  • The wallet addresses are not routing to any link for details. If they will not be clickable(which they should be), then they should be turned to normal text color.
    image

  • If the referesh button is also not needed, we should remove it from the ui then, as it is not working

Copy link

codeclimate bot commented Nov 25, 2024

Code Climate has analyzed commit a650fba and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

@Simplypheyie96 Simplypheyie96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are good now. Hopefully the other features would be added.

@invisiblemask invisiblemask merged commit 082a48a into main Nov 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate the API for HIiq UI IQ Token Stakers Dashboard
4 participants