Fix stubs #11
Merged
Fix stubs #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmurphy4
commented
Nov 27, 2024
| @@ -66,7 +66,7 @@ class item: | |||
| Retrieves the number of sub items. | |||
| """ | |||
|
|
|||
| def get_receipients(self) -> item: | |||
| def get_recipients(self) -> item: | |||
There was a problem hiding this comment.
kmurphy4
commented
Nov 27, 2024
Comment on lines
+94
to
+95
| def get_size(self) -> int: ... | ||
| def read_buffer(self, n: int) -> bytes: ... |
There was a problem hiding this comment.
kmurphy4
commented
Nov 27, 2024
| @@ -89,3 +89,7 @@ class item: | |||
| """ | |||
| Retrieves a specific attachment | |||
| """ | |||
|
|
|||
| def get_embedded_attachment(self, attachment_index: int) -> attachment: ... | |||
There was a problem hiding this comment.
kmurphy4
commented
Nov 27, 2024
stubs/pyproject.toml
Outdated
| @@ -6,5 +6,5 @@ build-backend = "setuptools.build_meta" | |||
| name = "pypff-stubs" | |||
| # The major version should match the version in `configure.ac`'s `AC_INIT` | |||
| # with the minor version incremented as needed for new changes. | |||
| version = "20240608.0" | |||
| version = "20240608.1rc1" | |||
There was a problem hiding this comment.
Once this is reviewed, I can change this to
Suggested change
| version = "20240608.1rc1" | |
| version = "20240608.1" |
and bump the version in https://github.com/Everlaw/servers/pull/37520.
There was a problem hiding this comment.
I checked that using these new stubs produces what I'd expect:
$ mypy src/tools/pst/
src/tools/pst/handler/impls/attachment.py:158: error: Unused "type: ignore" comment [unused-ignore]
get_size = ty.cast(ty.Callable[[], int], attach.get_size) # type: ignore[attr-defined]
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/tools/pst/handler/impls/attachment.py:159: error: Unused "type: ignore" comment [unused-ignore]
read_buffer = ty.cast(ty.Callable[[int], bytes], attach.read_buffer) # type: ignore[attr-defined]
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/tools/pst/handler/impls/attachment.py:261: error: Unused "type: ignore" comment [unused-ignore]
item.get_embedded_attachment, # type: ignore[attr-defined]
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/tools/pst/handler/impls/appt.py:284: error: Unused "type: ignore" comment [unused-ignore]
item.get_recipients(), # type: ignore[attr-defined]
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/tools/pst/handler/impls/eml.py:71: error: Unused "type: ignore" comment [unused-ignore]
item.get_recipients(), # type: ignore[attr-defined]
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Found 5 errors in 3 files (checked 15 source files)There was a problem hiding this comment.
255b8f7 - force-pushing that in..
|
LGTM! Go ahead and update/merge whenever you're ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some incorrect annotations while working on https://github.com/Everlaw/servers/pull/37520.